Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] Dont copy negative values on Transaction Details's amount. #10207

Merged
merged 2 commits into from Mar 23, 2023
Merged

[VDG] Dont copy negative values on Transaction Details's amount. #10207

merged 2 commits into from Mar 23, 2023

Conversation

jmacato
Copy link
Contributor

@jmacato jmacato commented Feb 28, 2023

Fixes #10154

cc @zkSNACKs/visual-design-group

@jmacato jmacato changed the title Dont copy negative values on Transaction Details's amount. [VDG] Dont copy negative values on Transaction Details's amount. Feb 28, 2023
MarnixCroes
MarnixCroes previously approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

soosr
soosr requested changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a proper fix would be to make the amount always a not negative value, and call the Amount field Incoming or Outgoing depending on what was the transaction.

WalletWasabi.Fluent/Views/Wallets/Home/History/Details/TransactionDetailsView.axaml Outdated Show resolved Hide resolved
yahiheb
yahiheb previously approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Yet Roland's comment here #10207 (review) makes sense, it makes the transaction details page better.

@soosr soosr dismissed stale reviews from yahiheb and MarnixCroes via bceb9b0 March 22, 2023 09:36
soosr
soosr approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr requested a review from yahiheb March 22, 2023 09:37
@soosr soosr merged commit b61a8bc into zkSNACKs:master Mar 23, 2023
4 of 5 checks passed
@molnard molnard mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soosr soosr soosr approved these changes

@MarnixCroes MarnixCroes MarnixCroes left review comments

@wieslawsoltes wieslawsoltes Awaiting requested review from wieslawsoltes

@yahiheb yahiheb Awaiting requested review from yahiheb

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy amount in tx details copies negative value
4 participants
@jmacato @soosr @yahiheb @MarnixCroes