[VDG] Fix less option sends the same amount

[soosr]

Fixes #7861

#7861 (comment):

We discussed this with @molnard. If the BnB found a solution with the same amount, only that one will be suggested. And also the text should be something more proper.

In this commit I moved a similar check to have everything in the same place.
I don't know how to test it, review it carefully.

[adamPetho]

tACK, only one suggestion on same amount.

[yahiheb]

It is not easy to understand the suggestion in this case if you do not pay attention to the fee.
IMO the change avoidance message should somehow emphasize that we are sending the same amount but using less fees.

Shouldn't we add some unit test for this case?

[soosr]

IMO the change avoidance message should somehow emphasize that we are sending the same amount but using less fees.

In general ACK, but should be well thought out about how to display that information too without overwhelming the user. (Notice it can be Less/More/Same too).
Out of the scope of this PR as this request should also apply for less/more options.

[SuperJMN]

It might be a good idea to extract out the suggestion generating algorithm outside the ViewModel. It's usually a good idea when algorithms are not quite obvious. It could also help testability.

[soosr]

Shouldn't we add some unit test for this case?

The guys are working to make the ViewModels testable, there will be a test for sure once they get to this point.

[yahiheb]

IMO the change avoidance message should somehow emphasize that we are sending the same amount but using less fees.

In general ACK, but should be well thought out about how to display that information too without overwhelming the user. (Notice it can be Less/More/Same too).
Out of the scope of this PR as this request should also apply for less/more options.

I created #10399 for this.

Shouldn't we add some unit test for this case?

The guys are working to make the ViewModels testable, there will be a test for sure once they get to this point.

We should keep track of these to not forget about them.

[yahiheb]

LGTM