[VDG] clear clipboard on leaving dialog

[soosr]

fixes #10523

[turbolay]

Just a question: No need to inform the user of this behavior?

[yahiheb]

tACK

[yahiheb]

Just a question: No need to inform the user of this behavior?

Good question but how would you do that?

[soosr]

Just a question: No need to inform the user of this behavior?

This question came up before, and it was said we don't have to expose implementation details in front of the user.

Good question but how would you do that?

I am personally not happy with the context menu. I mentioned several times that people don't know that they exist. And having a feature only available via the context menu is a bad approach.

I proposed a solution that is standard in Wasabi. When the cursor enters the recovery words area, in the bottom right a copy button could appear. And the tooltip could say Temporary copy the words. They will disappear from the clipboard once you left this page.

[yahiheb]

I am personally not happy with the context menu. I mentioned several times that people don't know that they exist. And having a feature only available via the context menu is a bad approach.

I proposed a solution that is standard in Wasabi. When the cursor enters the recovery words area, in the bottom right a copy button could appear. And the tooltip could say Temporary copy the words. They will disappear from the clipboard once you left this page.

If this feature was needed and users should know about it then I agree with your solution, it is better than the context menu. But my opinion is just to remove this feature/issue completely.

Currently we added it but we made it as hidden as possible which kind of indicates that we don't want users to know about it, which raises the question why did we add it then?

[Pule08]

@nopara73 what do you think about @soosr solution? Is it something which worth to finish?

[nopara73]

It seems this PR removes the 30 seconds timeout. Why?

[soosr]

It seems this PR removes the 30 seconds timeout. Why?

The clipboard will be cleared out when the user leaves the dialog. IMO this approach makes more sense and it is more consistent as #10523 suggests it.

@nopara73 what do you think about @soosr solution? Is it something which worth to finish?

This question was for this #10558 (comment) comment.
What do you think about the proposed solution:

When the cursor enters the recovery words area, in the bottom right a copy button could appear. And the tooltip could say Temporary copy the words. They will disappear from the clipboard once you left this page.

[nopara73]

1. Makes sense. I didn't think of it that way.
2. No.

[nopara73]

cACK. Code LGTM. Didn't test.

[yahiheb]

tACK