[VDG] Unfocus SearchBar on Escape key

[SuperJMN]

Focusing away is the only method to hide the popup. We focus MainWindow so the SearchBar automatically closes its popup.

WalletWasabi.Fluent.Desktop_Cz4FY1zyN2.mp4

I've tried other solutions, but the UX is was bad. Just closing the flyout makes the keyboard caret stay inside without any feedback.

This is a good solution IMHO because, by definition, the searchbar will show the flyout whenever it's focused.

Fixes #10691

[wieslawsoltes]

mainWindow.Focus()

[wieslawsoltes]

WalletWasabi/WalletWasabi.Fluent/Behaviors/ExecuteCommandOnKeyDownBehavior.cs

Line 68 in acbb6f5

inputRoot.AddDisposableHandler(InputElement.KeyDownEvent, RootDefaultKeyDown, EventRoutingStrategy)

[SuperJMN]

What do you mean?

[wieslawsoltes]

Why listen for changes just not use AddDisposableHandler as in linked behavior

[SuperJMN]

AddDisposableHandler creates a subscription, but my the pipeline requires IObservable<T>. That's why I use OnEvent instead.

		if (AssociatedObject is InputElement element)
		{
			this.WhenAnyValue(x => x.EventRoutingStrategy, x => x.Key, (strategy, key) => new { Key = key, RoutingStrategy = strategy })
				.Select(args => element.OnEvent(InputElement.KeyDownEvent, args.RoutingStrategy).Where(x => x.EventArgs.Key == args.Key))
				.Switch()
				.Do(_ => Interaction.ExecuteActions(AssociatedObject, Actions, null))
				.Subscribe()
				.DisposeWith(_disposables);
		}

[SuperJMN]

We can discuss which way is better if you show me how you'd implement it using AddDisposableHandler. I discarded it because the handler it takes doesn't fit well with the reactive paradigm.

[soosr]

I think what @wieslawsoltes meant is it is very unlikely that either EventRoutingStrategy or Key will ever change during runtime, so observing for changes is unnecessary and just increases the complexity.

With his suggestion, you could do:

_subscription = element.AddDisposableHandler(InputElement.KeyDownEvent, OnKeyDown, EventRoutingStrategy);

private void OnKeyDown(object? sender, KeyEventArgs e)
{
	if (e.Key == Key)
	{
		Interaction.ExecuteActions(AssociatedObject, Actions, null);
	}
}

And also I think it would make sense to have a similar class like DisposingBehavior called DisposingTrigger. So the disposing could happen as usual and would also simplify a bit as you could do .DisposeWith(disposable);

[yahiheb]

tACK

[soosr]

tACK

[soosr]

IMO we should have a flag like SearchBar.IsActive and we should just modify that one value. And when it is false, the flyout should close and SearchBar should lose focus.

And everything should control that one flag. It is getting complex to handle every edge case.
Anyway, this is out of the scope of this PR.