Simplify fee estimations from mempool #10818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
reviewed
May 30, 2023
kiminuo
reviewed
May 30, 2023
kiminuo
reviewed
May 30, 2023
adamPetho
reviewed
May 31, 2023
adamPetho
reviewed
Jun 2, 2023
|
I found it, it was confusing block size in megabytes with virtual megabytes. Please @adamPetho take a look now. |
adamPetho
approved these changes
Jun 5, 2023
| var (sanityFeeRate, minEstimations) = GetFeeEstimationsFromMempoolInfo(mempoolInfo); | ||
|
|
||
| var minEstimations = GetFeeEstimationsFromMempoolInfo(mempoolInfo); | ||
| var minEstimationFor260Mb = new FeeRate((decimal)minEstimations.GetValueOrDefault(260 / 4)); |
There was a problem hiding this comment.
260 / 4 How come this? I don't get it.
There was a problem hiding this comment.
there is no way to know how many bytes a virtual byte is in this context so, we could think that 4 virtual bytes are more or less equivalent to 1 real byte. I mean, the mempool size is in real bytes while everything else is expressed in virtual bytes, we need a way to "convert" virtual bytes to real bytes or real bytes to virtual byte.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies a bit the logic for estimating the minimum feerate to pay according to the mempool histogram and updates the UTs to use more recent data.
Please @adamPetho take a deep look.