[refactoring] RPCClientExtensions: Simplify
#10852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is always the same
…pass always the same value
…veSmartFeeAsync` (to avoid behavior change) + remove `simulateIfRegTest` parameter
… parameter which is always true
kiminuo
force-pushed
the
feature/2023-06-05-simplify-feerate-calls
branch
from
ba72d82
to
66e2efe
Compare
kiminuo
commented
Jun 6, 2023
| @@ -937,7 +937,7 @@ public static async Task<(Money feePerInputs, Money feePerOutputs)> CalculateFee | |||
| var outputSizeInBytes = Constants.OutputSizeInBytes; | |||
| try | |||
| { | |||
| var feeRate = (await rpc.EstimateSmartFeeAsync(confirmationTarget, EstimateSmartFeeMode.Conservative, simulateIfRegTest: true).ConfigureAwait(false)).FeeRate; | |||
| var feeRate = (await rpc.EstimateConservativeSmartFeeAsync(confirmationTarget).ConfigureAwait(false)).FeeRate; | |||
There was a problem hiding this comment.
The method was renamed because otherwise a different EstimateSmartFeeAsync method would be called. Not ours in WalletWasabi/Extensions/RPCClientExtensions.cs.
kiminuo
force-pushed
the
feature/2023-06-05-simplify-feerate-calls
branch
from
f22033d
to
4e07e3c
Compare
YohDeadfall
approved these changes
Jun 7, 2023
lontivero
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10818 (comment)