Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linux popup and flyout issues. #12497

Merged

Conversation

danwalmsley
Copy link

@danwalmsley danwalmsley commented Feb 19, 2024

Fixes #12412

@danwalmsley danwalmsley changed the title Fix Linux popup and flyout issues. DO NOT MERGE: Fix Linux popup and flyout issues. Feb 19, 2024
@MaxHillebrand MaxHillebrand added this to the v2.0.6 milestone Feb 19, 2024
Copy link
Collaborator

@Whem Whem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on Debian 12 and its works as well, but its only works if I change the Nuget.Config file :

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="nuget" value="https://api.nuget.org/v3/index.json" />
    <add key="avalonia-all" value="https://nuget-feed-all.avaloniaui.net/v3/index.json" />
  </packageSources>
  <packageSourceMapping>
    <packageSource key="avalonia-all">
      <package pattern="*" />
    </packageSource>
    <packageSource key="nuget">
      <package pattern="*" />
    </packageSource>
  </packageSourceMapping>
</configuration>

@soosr soosr changed the title DO NOT MERGE: Fix Linux popup and flyout issues. Fix Linux popup and flyout issues. Feb 20, 2024
@soosr
Copy link
Collaborator

soosr commented Feb 20, 2024

@MarnixCroes @Whem Could you guys do a final test? If Flyouts are working

@Whem Whem self-requested a review February 20, 2024 13:45
Copy link
Collaborator

@Whem Whem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't build, CI also failing

@soosr soosr closed this Feb 20, 2024
@molnard
Copy link
Collaborator

molnard commented Feb 20, 2024

@danwalmsley I was not able to add my commit to this PR. Please fix it.

Steps for the Contributor

  • Ensure the "Allow edits from maintainers" checkbox is selected for the PR.
  • Check their fork's settings for any restrictions that might prevent maintainers from pushing commits.

@danwalmsley danwalmsley reopened this Feb 20, 2024
@molnard molnard merged commit 93d6b35 into zkSNACKs:master Feb 20, 2024
3 of 8 checks passed
@MarnixCroes
Copy link
Collaborator

MarnixCroes commented Feb 20, 2024

@molnard was this merged on purpose? #12505 would be enough, no?
master is broken now

@molnard
Copy link
Collaborator

molnard commented Feb 20, 2024

Thx for noticing. If I merge another PR that is based on this - this will look like merged, however I merged #12506

@molnard
Copy link
Collaborator

molnard commented Feb 20, 2024

master is broken now

Hmm then I overlooked something. It is working for me. How is it broken for you @MarnixCroes ?

@MarnixCroes
Copy link
Collaborator

running 87f8eef, I got errors like this and failing to start
twice after dotnet run

error NU1301: Failed to retrieve information about 'Avalonia' from remote source 'https://nuget-feed-all.avaloniaui.net/v3/package/avalonia/index.json'.

but now trying again, still running 87f8eef, it's working.
so idk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[master] navbar wallet name tooltip spacing is broken
7 participants