Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Linux popup and flyout issues 2 #12505

Merged
merged 7 commits into from Feb 20, 2024
Merged

Fix Linux popup and flyout issues 2 #12505

merged 7 commits into from Feb 20, 2024

Conversation

molnard
Copy link
Collaborator

@molnard molnard commented Feb 20, 2024 •
edited

Base on #12497

Plus the addition to fix the nuget base on Whem solution.

I was not able to push to that branch.

@molnard molnard marked this pull request as ready for review February 20, 2024 13:57
soosr
soosr previously approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds for me.

@molnard molnard mentioned this pull request Feb 20, 2024
Merged
MarnixCroes
MarnixCroes reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pop up and flyout issues are fixed,
however the musicbox is missing the play icon
image

@molnard
Copy link
Collaborator Author

molnard commented Feb 20, 2024

Wrong password text is missing

image

@soosr
Copy link
Collaborator

soosr commented Feb 20, 2024

pop up and flyout issues are fixed, however the musicbox is missing the play icon image

Its the same issue that would have the new release fix. It uses Inlines which is buggy, we shouldn't release with it. #12507

@MarnixCroes
Copy link
Collaborator

MarnixCroes commented Feb 20, 2024 •
edited

pop up and flyout issues are fixed, however the musicbox is missing the play icon image

Its the same issue that would have the new release fix. It uses Inlines which is buggy, we shouldn't release with it. #12507

I added 075efd2 to this branch, and ran it.
Then it shows the word Play like previously, instead of the icon?
master is ok

@molnard molnard marked this pull request as draft February 20, 2024 14:54
soosr
soosr approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK win11

@molnard molnard marked this pull request as ready for review February 20, 2024 15:15
molnard
molnard commented Feb 20, 2024
View reviewed changes
Copy link
Collaborator Author

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK - CI seems to pass

@molnard molnard merged commit 87f8eef into zkSNACKs:master Feb 20, 2024
5 of 7 checks passed
@MarnixCroes MarnixCroes mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarnixCroes MarnixCroes MarnixCroes left review comments

@soosr soosr soosr approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@molnard @soosr @MarnixCroes @09128319047