[UI] Merge Wallet & Coinjoin settings

[wieslawsoltes]

Fixes #12351

[soosr]

@wieslawsoltes Do you need any help with this?

[wieslawsoltes]

@wieslawsoltes Do you need any help with this?

Don't need it just requires further refactoring

[MarnixCroes]

• click on Change coinjoin strategy -> navigate back (back or continue button) -> it navigates to the General tab, instead of the expected coinjoin tab

• coinjoin strategy can be missing: click on change coinjoin strategy -> click back without changing anything
  

[wieslawsoltes]

• click on Change coinjoin strategy -> navigate back (back or continue button) -> it navigates to the General tab, instead of the expected coinjoin tab

Can't repro:

screencast.2024-03-13.10-12-02.mp4

[wieslawsoltes]

• coinjoin strategy can be missing: click on change coinjoin strategy -> click back without changing anything
  

What do you mean by missing ?

[soosr]

• coinjoin strategy can be missing: click on change coinjoin strategy -> click back without changing anything
  

What do you mean by missing ?

The name of the selected profile should appear next to the Coinjoin strategy: text. Can repro:

[wieslawsoltes]

• coinjoin strategy can be missing: click on change coinjoin strategy -> click back without changing anything
  

What do you mean by missing ?

The name of the selected profile should appear next to the Coinjoin strategy: text. Can repro:

Ah ok will fix it :)

[soosr]

• click on Change coinjoin strategy -> navigate back (back or continue button) -> it navigates to the General tab, instead of the expected coinjoin tab

Can't repro: https://github.com/zkSNACKs/WalletWasabi/assets/2297442/eac3b1cd-14c6-4c36-9985-90383ddc2903

Cannot repro either. @MarnixCroes Are you on the latest commit?

[MarnixCroes]

• click on Change coinjoin strategy -> navigate back (back or continue button) -> it navigates to the General tab, instead of the expected coinjoin tab

Can't repro: https://github.com/zkSNACKs/WalletWasabi/assets/2297442/eac3b1cd-14c6-4c36-9985-90383ddc2903

Cannot repro either. @MarnixCroes Are you on the latest commit?

tried several things, can't repro anymore. ed97729

[wieslawsoltes]

Update coinjoin settings

• coinjoin strategy can be missing: click on change coinjoin strategy -> click back without changing anything
  

What do you mean by missing ?

The name of the selected profile should appear next to the Coinjoin strategy: text. Can repro:

Ah ok will fix it :)

Fix 3347e20

[soosr]

minor things

[MarnixCroes]

also, why the creation of two tabs for backup and general?
why not keep them on the same tab?

[yahiheb]

I have noticed some weird behavior with the coinjoin strategy settings but not related to this PR. #12667

I tested this a bit, LGTM.

[soosr]

last bit

[soosr]

Please rename also the file for consistency

[wieslawsoltes]

ok made some more renaming 86efd19

[yahiheb]

also, why the creation of two tabs for backup and general?
why not keep them on the same tab?

This suggestion makes more sense now that we have a Tools tab instead of backup since renaming a wallet is more suited to be in the Tools tab and that there are plans to add Delete Wallet and Resync Wallet actions.

As it is now the General tab is completely empty, so removing it and making the Coinjoin the default is better UX imo.

[soosr]

This suggestion makes more sense now that we have a Tools tab instead of backup since renaming a wallet is more suited to be in the Tools tab and that there are plans to add Delete Wallet and Resync Wallet actions.

Wallet name is not an action, it's a property that can be changed. While the others are actions that fit in tools tab.

As it is now the General tab is completely empty, so removing it and making the Coinjoin the default is better UX IMO.

It's not empty for HW wallets.

[soosr]

tACK. Good Job!