[VDG] Privacy Progress N/A when balance is zero #12575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soosr Also, just a suggestion: maybe we can add a cool, marketing heavy tooltip when this appears such as: "Move your BTC into Wasabi and make them fully private now!" or something? |
ichthus1604
changed the title
yahiheb
reviewed
Feb 29, 2024
I can repro, @ichthus1604 please take a look. |
soosr
reviewed
Mar 11, 2024
soosr
reviewed
Mar 14, 2024
| @@ -233,7 +233,7 @@ public int GetPrivacyPercentage() | |||
| { | |||
| var currentPrivacyScore = Coins.Sum(x => x.Amount.Satoshi * Math.Min(x.HdPubKey.AnonymitySet - 1, x.IsPrivate(AnonScoreTarget) ? AnonScoreTarget - 1 : AnonScoreTarget - 2)); | |||
| var maxPrivacyScore = Coins.TotalAmount().Satoshi * (AnonScoreTarget - 1); | |||
| int pcPrivate = maxPrivacyScore == 0M ? 100 : (int)(currentPrivacyScore * 100 / maxPrivacyScore); | |||
| int pcPrivate = maxPrivacyScore == 0M ? 0 : (int)(currentPrivacyScore * 100 / maxPrivacyScore); | |||
There was a problem hiding this comment.
Could someone from the @zkSNACKs/code-team verify that this doesn't break anything in CJ code? @adamPetho @molnard
There was a problem hiding this comment.
I've looked and I think it's OK because we are in cases where we don't have any coins anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9543
I tried
-as mentioned here but it looks really ugly: