Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hwi update to 2.4.0 #12616

Merged
merged 3 commits into from Mar 6, 2024
Merged

Hwi update to 2.4.0 #12616

merged 3 commits into from Mar 6, 2024

Conversation

Whem
Copy link
Collaborator

@Whem Whem commented Mar 5, 2024 •
edited

Fixes: #12285

Changelog:

  • Support for Trezor Safe 3
  • Improved error handling for invalid descriptors and Ledger device errors

Tested with RC4

Devices

  • Coldcard MK2
  • Coldcard MK3
  • Coldcard MK4
  • Ledger Nano X
  • Ledger Nano S
  • Ledger Nano S PLus
  • Blockstream Jade
  • Bitbox02
  • Trezor One
  • Trezor T

Operating Systems

  • Windows 11
  • MacOs
  • Ubuntu 22.0
  • Debian 12.0

Testing phases

  • Check firmware updates
  • Detect device
  • Send
  • Receive
  • Hwi Katas Test

Main net full test

  • Jade Windwos
  • Jade Ubuntu
  • BitBox02 MacOs
  • Coldcard Debian

@Whem Whem changed the title Hwi update Hwi update to 2.4.0 Mar 5, 2024
kristapsk
kristapsk approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cr utACK. Checked that hashes are correct and that they match https://github.com/bitcoin-core/HWI/releases/tag/2.4.0.

@Whem Whem marked this pull request as ready for review March 6, 2024 14:23
adamPetho
adamPetho approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@adamPetho adamPetho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamPetho adamPetho requested a review from yahiheb March 6, 2024 14:53
molnard
molnard approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@molnard molnard merged commit 6b2ac23 into zkSNACKs:master Mar 6, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapsk kristapsk kristapsk approved these changes

@molnard molnard molnard approved these changes

@adamPetho adamPetho adamPetho approved these changes

@yahiheb yahiheb Awaiting requested review from yahiheb

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to HWI 2.4.0
4 participants
@Whem @kristapsk @molnard @adamPetho