TryRemoveLastFilterIfNewerThanAsync should not throw
#12778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kiminuo
reviewed
Apr 8, 2024
| @@ -317,14 +317,14 @@ public async Task<FilterModel[]> FetchBatchAsync(uint fromHeight, int batchSize, | |||
| { | |||
| if (!IndexStorage.TryRemoveLast(out filter)) | |||
| { | |||
| throw new InvalidOperationException("No last filter."); | |||
| return null; | |||
There was a problem hiding this comment.
So this is important when there are no blocks in the database, right?
There was a problem hiding this comment.
I think there was some history about why we throw the exception but I can't recall why we did it and given the method's name and what it does I would expect the method NOT to throw, so I think it's a good change.
kiminuo
approved these changes
Apr 8, 2024
|
I merged this because it cannot change anything in the current behaviour, but it makes the usage consistent with what can happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tryimplies that the function doesn'tthrowRemoveAllNewerThanAsyncuses it as if it was not throwing (otherwise, how can it returnnull???)It's the problem here: #12400 (comment)