Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No password check in WatchOnly wallets #2186

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@molnard
Copy link
Collaborator

commented Aug 28, 2019

Fixes: #2184
When I added the compatibility/notification functions I also added a Password check before the BuildTx which cannot be done with watch-only wallets.
d7fde2d#diff-bc431b4bc31acb6d49cd62c6288310e7R321

@molnard molnard requested a review from nopara73 Aug 28, 2019

@lontivero
Copy link
Collaborator

left a comment

The change is crystal clear but I have no a HW to test it. Anyway, I assume you did it.

@nopara73 nopara73 merged commit b392506 into zkSNACKs:master Aug 28, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190828.1 succeeded
Details
Wasabi.Osx #20190828.2 succeeded
Details
Wasabi.Windows #20190828.1 succeeded
Details
@davterra

This comment has been minimized.

Copy link

commented Aug 28, 2019

Works fine for me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.