Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validations system refactor. #2223

Merged
merged 24 commits into from Sep 10, 2019
Merged

Validations system refactor. #2223

merged 24 commits into from Sep 10, 2019

Commits on Sep 9, 2019

  1. Add Error description classes.

    @jmacato
    jmacato committed Sep 9, 2019
    Copy the full SHA
    52f4b18 View commit details
    Browse the repository at this point in the history

  2. Refactoring Validation methods.

    @jmacato
    jmacato committed Sep 9, 2019
    Copy the full SHA
    47667ea View commit details
    Browse the repository at this point in the history

  3. Fix logic.

    @jmacato
    jmacato committed Sep 9, 2019
    Copy the full SHA
    4454987 View commit details
    Browse the repository at this point in the history

  4. Cache validation method information.

    @jmacato
    jmacato committed Sep 9, 2019
    Copy the full SHA
    414588e View commit details
    Browse the repository at this point in the history

  5. Address reviews.

    @jmacato
    jmacato committed Sep 9, 2019
    Copy the full SHA
    c9563ad View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary propchange hook.

    @jmacato
    jmacato committed Sep 9, 2019
    Copy the full SHA
    05cbd13 View commit details
    Browse the repository at this point in the history

  7. Serialize then Deserialize via Converter the ErrorDescriptor as a wor… 

    …karound. Remove this hack when we update to Avalonia 0.9.
    @jmacato
    jmacato committed Sep 9, 2019
    Copy the full SHA
    11bad9d View commit details
    Browse the repository at this point in the history

  8. Address CodeFactor.

    @jmacato
    jmacato committed Sep 9, 2019
    Copy the full SHA
    b1f523e View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. Use yield return instead of allocating new list.

    @jmacato
    jmacato committed Sep 10, 2019
    Copy the full SHA
    2575a87 View commit details
    Browse the repository at this point in the history

  2. Add a new converter to convert ErrorSeverity into a SolidColorBrush.

    @jmacato
    jmacato committed Sep 10, 2019
    Copy the full SHA
    54377f4 View commit details
    Browse the repository at this point in the history

  3. Add some tests.

    @molnard
    molnard committed Sep 10, 2019
    Copy the full SHA
    4520023 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'error-template-revamp' of https://github.com/jmacato/Wa… 

    …lletWasabi
    @molnard
    molnard committed Sep 10, 2019
    Copy the full SHA
    280ecf8 View commit details
    Browse the repository at this point in the history

  5. fix test

    @molnard
    molnard committed Sep 10, 2019
    Copy the full SHA
    dbd7ef1 View commit details
    Browse the repository at this point in the history

  6. Code style fix.

    @molnard
    molnard committed Sep 10, 2019
    Copy the full SHA
    1680c7e View commit details
    Browse the repository at this point in the history

  7. Test fix

    @molnard
    molnard committed Sep 10, 2019
    Copy the full SHA
    9ad5d34 View commit details
    Browse the repository at this point in the history

  8. Code clean.

    @molnard
    molnard committed Sep 10, 2019
    Copy the full SHA
    e0f3033 View commit details
    Browse the repository at this point in the history

  9. Add a converter that colors the border according to 

    aggregated error severities.
    @jmacato
    jmacato committed Sep 10, 2019
    Copy the full SHA
    95a12f2 View commit details
    Browse the repository at this point in the history

  10. Fix bug when changing viewmodels on startup page.

    @jmacato
    jmacato committed Sep 10, 2019
    Copy the full SHA
    af5b078 View commit details
    Browse the repository at this point in the history

  11. Remov vestigial code.

    @jmacato
    jmacato committed Sep 10, 2019
    Copy the full SHA
    5a59c02 View commit details
    Browse the repository at this point in the history

  12. Change style priorities.

    @jmacato
    jmacato committed Sep 10, 2019
    Copy the full SHA
    cc14bce View commit details
    Browse the repository at this point in the history

  13. Address Codefactor.

    @jmacato
    jmacato committed Sep 10, 2019
    Copy the full SHA
    af86ea5 View commit details
    Browse the repository at this point in the history

  14. Add Validation selector for PasswordBox.

    @jmacato
    jmacato committed Sep 10, 2019
    Copy the full SHA
    357d34a View commit details
    Browse the repository at this point in the history

  15. Code clean.

    @molnard
    molnard committed Sep 10, 2019
    Copy the full SHA
    577daa3 View commit details
    Browse the repository at this point in the history

  16. Adjust error levels

    @molnard
    molnard committed Sep 10, 2019
    Copy the full SHA
    072f019 View commit details
    Browse the repository at this point in the history