Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update avalonia with many fixes (0.9.2) #2988

Merged
merged 2 commits into from Jan 21, 2020
Merged

update avalonia with many fixes (0.9.2) #2988

merged 2 commits into from Jan 21, 2020

Conversation

danwalmsley
Copy link

@danwalmsley danwalmsley commented Jan 20, 2020 •
edited

This updates Avalonia with the following fixes: (ones we are interested in bold)

  • OSX fix artifacts in window corners
  • Fix referencing Resources in MergedDictionaries
  • Latest itemsrepeater fixes (from msft)
  • ImmediateRenderer hittesting fixed
  • SelectingItemsControl fixes
  • Support Image.StretchDirection
  • Win32 Right hand keymodifiers reported correctly
  • OSX Dont swallow exceptions across native boundaries
  • X11 (NixOS and WSL) dont crash with invalid monitor / window size.

Fixes:
#2856
OSX exception swallowing.

Probably fixes:
#2939

@danwalmsley danwalmsley mentioned this pull request Jan 20, 2020
Closed
MaxHillebrand
MaxHillebrand approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Qubes 4 Debian 10

I'm not sure what to test, as all these fixes you describe are not relevant for my environment... But everything seems to work fine, I see no UI glitches, and there are unusual errors in the log.

molnard
molnard approved these changes Jan 21, 2020
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK! (win, mac)

@danwalmsley
Copy link
Author

danwalmsley commented Jan 21, 2020 •
edited

Iv tested Win, Mac, need some more linux testing I think.

As it would be nice to confirm if #2939 is fixed.

@molnard
Copy link
Collaborator

molnard commented Jan 21, 2020 •
edited

I added linux heros to the reviewers.

@lontivero
Copy link
Collaborator

@danwalmsley, I didn't review or test it yet neither but this branch is in the walletwasabi repo and it should be a branch in your own repo.

lontivero
lontivero approved these changes Jan 21, 2020
View reviewed changes
Copy link
Collaborator

@lontivero lontivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ubuntu Linux, everything seems to work okay. Honestly, I don't know what to test in this case but whatever I do works okay.

@nopara73 nopara73 merged commit 1f31430 into master Jan 21, 2020
@nopara73 nopara73 deleted the update-avalonia branch January 21, 2020 21:01
@nopara73
Copy link
Contributor

Backporting or not safe enough?

@nopara73 nopara73 mentioned this pull request Jan 21, 2020
Closed
@yahiheb yahiheb mentioned this pull request Jan 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lontivero lontivero lontivero approved these changes

@molnard molnard molnard approved these changes

@MaxHillebrand MaxHillebrand MaxHillebrand approved these changes

@jmacato jmacato Awaiting requested review from jmacato

@yahiheb yahiheb Awaiting requested review from yahiheb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danwalmsley @molnard @lontivero @nopara73 @MaxHillebrand