Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProcessBridge refactoring & bugfix #3858

Closed
wants to merge 7 commits into from
Closed

ProcessBridge refactoring & bugfix #3858

wants to merge 7 commits into from

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Jul 3, 2020 •
edited

This PR is supposed to fix: #3852 (comment)

It should be probably discussed after the Wasabi release.

Follow-up:

  • The design of the class could be improved further by using a builder pattern and simply passing it to ProcessBridge. Without it, it's necessary to add new arguments whenever any new functionality is needed (example)

@kiminuo kiminuo force-pushed the feature/2020-07-processBridge-refactoring branch 6 times, most recently from 063e9e2 to adbbd9a Compare July 3, 2020 13:54
@kiminuo kiminuo marked this pull request as ready for review July 3, 2020 14:09
yahiheb
yahiheb reviewed Jul 3, 2020
View reviewed changes
WalletWasabi.Tests/UnitTests/Microservices/ProcessBridgeTest.cs Outdated
using var cts = new CancellationTokenSource();
cts.Cancel();
var processBridge = new ProcessBridge(MicroserviceHelpers.GetBinaryPath("bitcoind"));
(string response, int exitCode) p = await processBridge.SendCommandAsync("-testnet", openConsole: false, cts.Token);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be --testnet or -testnet?

Copy link
Collaborator

@lontivero lontivero Jul 3, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For bitcoind the switch is -testnet

@kiminuo kiminuo marked this pull request as draft July 3, 2020 20:46
@kiminuo kiminuo force-pushed the feature/2020-07-processBridge-refactoring branch 4 times, most recently from 4ce73c8 to e1e161e Compare July 4, 2020 11:09
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Jul 4, 2020
@kiminuo kiminuo force-pushed the feature/2020-07-processBridge-refactoring branch 2 times, most recently from 56867d1 to b5977d4 Compare July 4, 2020 11:34
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Jul 4, 2020
@kiminuo kiminuo force-pushed the feature/2020-07-processBridge-refactoring branch from b5977d4 to 2ada212 Compare July 4, 2020 11:43
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Jul 4, 2020
@kiminuo kiminuo force-pushed the feature/2020-07-processBridge-refactoring branch 4 times, most recently from ba6fb25 to 528e007 Compare July 4, 2020 12:23
@kiminuo kiminuo marked this pull request as ready for review July 4, 2020 12:30
yahiheb
yahiheb requested changes Jul 4, 2020
View reviewed changes
WalletWasabi/Helpers/EnvironmentHelpers.cs Outdated Show resolved Hide resolved
WalletWasabi/Microservices/ProcessBridge.cs Outdated Show resolved Hide resolved
@kiminuo kiminuo force-pushed the feature/2020-07-processBridge-refactoring branch from 054221c to 200d1fc Compare July 5, 2020 08:39
@kiminuo kiminuo force-pushed the feature/2020-07-processBridge-refactoring branch from 200d1fc to 92e3a4f Compare July 5, 2020 13:53
@kiminuo kiminuo changed the title ProcessBridge refactoring ProcessBridge refactoring & bugfix Jul 6, 2020
@kiminuo
Copy link
Collaborator Author

kiminuo commented Jul 6, 2020

@molnard @lontivero Wdyt? It contains a bugfix but it's also large change. I would say, it's better to wait with this after release given that the bug should manifest itself very rarely.

Finished refactoring is here: #3863 but it's extra large.

@molnard
Copy link
Collaborator

molnard commented Jul 6, 2020

@molnard @lontivero Wdyt? It contains a bugfix but it's also large change. I would say, it's better to wait with this after release given that the bug should manifest itself very rarely.

Finished refactoring is here: #3863 but it's extra large.

Yes, it looks like a big change and IMO the discussion on this will be too. After the release...

@kiminuo
Copy link
Collaborator Author

kiminuo commented Aug 8, 2020

Superseded by #3863.

@kiminuo kiminuo closed this Aug 8, 2020
@kiminuo kiminuo deleted the feature/2020-07-processBridge-refactoring branch September 30, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lontivero lontivero lontivero left review comments

@yahiheb yahiheb yahiheb requested changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kiminuo @molnard @lontivero @yahiheb