Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fix-'To Bitcoin address' instead of 'Via' #6731

Merged
merged 1 commit into from Nov 26, 2021
Merged

Typo fix-'To Bitcoin address' instead of 'Via' #6731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion WalletWasabi.Fluent/Views/Wallets/Send/TransactionPreviewView.axaml
View file
Open in desktop
Expand Up @@ -49,7 +49,7 @@

<Separator />
<c:PreviewItem Icon="{StaticResource transceive_regular}"
Text="via Bitcoin address">
Text="To Bitcoin address">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Text="To Bitcoin address">
Text="to Bitcoin address">

should be lower case to flow in the whole sentence.

to is better than via.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, it should not!

All other lines start capitalized too.

Copy link
Collaborator

@soosr soosr Nov 23, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial plan was as @yahiheb described. But since then the things have changed... New rows added... Order changed.
I would say should be lower case if there is no separator between the two sections, otherwise capitalized.

<TextBox Classes="selectableTextBlock" Text="{Binding AddressText, FallbackValue=btc029382398fkj34f98df239823}" />
</c:PreviewItem>
<Separator />
Expand Down