[VDG] Recovery Words improvements #9064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxHillebrand
previously approved these changes
Sep 8, 2022
jmacato
suggested changes
Sep 9, 2022
WalletWasabi.Fluent/Views/AddWallet/Create/RecoveryWordsView.axaml
Outdated
Show resolved
Hide resolved
nopara73
dismissed stale reviews from yahiheb, MaxHillebrand, and themself
via
0d392c1
…xaml Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
|
The caption and the warning message have similar parts, one of them is redundant and I think they could be merged. BTW guys... Is it only me? But the view looks vertically crowded. |
|
At the lowest window height, the scrollbar appears and the warning message is not visible. This might not be an issue, but it is another argument for solution 6 here #8941 (comment). If it only bothers me then ignore my comment.
|
|
tACK. Well done! Fixes #8941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements proposed design 4 from here
Adds a warning letting the user know they will not see these words again.
Fixes Misleading order of recovery words #8941