[VDG] Escape button goes back #9691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
soosr
requested changes
Mar 20, 2023
WalletWasabi.Fluent/ViewModels/Wallets/Receive/ReceiveAddressViewModel.cs
Outdated
Show resolved
Hide resolved
nopara73
previously approved these changes
Mar 29, 2023
There was a problem hiding this comment.
LGTM
Fight this out with @soosr. Any behavior is fine by me: #9691 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9984
Partially fixes: #9983
Added new option to SetupCancel method to override Escape button behavior and enable back navigation.
Dialogs:
Dialogs:
SetupCancel:
All routable view models:
ViewModels/AddWallet/AddWalletPageViewModel
ViewModels/AddWallet/AddedWalletPageViewModel
ViewModels/AddWallet/Create/ConfirmRecoveryWordsViewModel
ViewModels/AddWallet/Create/RecoveryWordsViewModel
ViewModels/AddWallet/HardwareWallet/ConnectHardwareWalletViewModel
ViewModels/AddWallet/HardwareWallet/DetectedHardwareWalletViewModel
ViewModels/AddWallet/LegalDocumentsViewModel
ViewModels/AddWallet/RecoverWalletViewModel
ViewModels/AddWallet/TermsAndConditionsViewModel
ViewModels/AddWallet/WalletNamePageViewModel
ViewModels/AddWallet/WelcomePageViewModel
ViewModels/CoinControl/SelectCoinsDialogViewModel
ViewModels/CoinJoinProfiles/CoinJoinProfilesViewModel
ViewModels/Dialogs/AboutAdvancedInfoViewModel
ViewModels/Dialogs/AddressEntryDialogViewModel
ViewModels/Dialogs/AdvancedRecoveryOptionsViewModel
ViewModels/Dialogs/Authorization/AuthorizationDialogBase
ViewModels/Dialogs/Authorization/HardwareWalletAuthDialogViewModel
ViewModels/Dialogs/Authorization/PasswordAuthDialogViewModel
ViewModels/Dialogs/Base/DialogViewModelBase
ViewModels/Dialogs/Base/DialogViewModelBase
ViewModels/Dialogs/ConfirmHideAddressViewModel
ViewModels/Dialogs/CreatePasswordDialogViewModel
ViewModels/Dialogs/LabelEntryDialogViewModel
ViewModels/Dialogs/ManualCoinJoinProfileDialogViewModel
ViewModels/Dialogs/ShowErrorDialogViewModel
ViewModels/Dialogs/ShowQrCameraDialogViewModel
ViewModels/Dialogs/ShuttingDownViewModel
ViewModels/HelpAndSupport/AboutViewModel
ViewModels/HelpAndSupport/BugReportLinkViewModel
ViewModels/HelpAndSupport/DocsLinkViewModel
ViewModels/HelpAndSupport/UserSupportViewModel
ViewModels/Login/LoginViewModel
ViewModels/Login/PasswordFinder/ContainsNumbersViewModel
ViewModels/Login/PasswordFinder/ContainsSymbolsViewModel
ViewModels/Login/PasswordFinder/PasswordFinderIntroduceViewModel
ViewModels/Login/PasswordFinder/PasswordFoundViewModel
ViewModels/Login/PasswordFinder/PasswordNotFoundViewModel
ViewModels/Login/PasswordFinder/SearchPasswordViewModel
ViewModels/Login/PasswordFinder/SelectCharsetViewModel
ViewModels/NavBar/NavBarItemViewModel
ViewModels/OpenDirectory/OpenConfigFileViewModel
ViewModels/OpenDirectory/OpenDataFolderViewModel
ViewModels/OpenDirectory/OpenFileViewModel
ViewModels/OpenDirectory/OpenLogsViewModel
ViewModels/OpenDirectory/OpenTorLogsViewModel
ViewModels/OpenDirectory/OpenWalletsFolderViewModel
ViewModels/Settings/AdvancedSettingsTabViewModel
ViewModels/Settings/BitcoinTabSettingsViewModel
ViewModels/Settings/GeneralSettingsTabViewModel
ViewModels/Settings/PrivacyModeViewModel
ViewModels/Settings/SettingsPageViewModel
ViewModels/Settings/SettingsTabViewModelBase
ViewModels/Settings/ThemeChangeViewModel
ViewModels/SuccessViewModel
ViewModels/TransactionBroadcasting/BroadcastTransactionViewModel
ViewModels/TransactionBroadcasting/BroadcasterViewModel
ViewModels/TransactionBroadcasting/LoadTransactionViewModel
ViewModels/TriggerCommandViewModel
ViewModels/Wallets/Advanced/WalletCoins/WalletCoinsViewModel
ViewModels/Wallets/Advanced/WalletInfoViewModel
ViewModels/Wallets/Advanced/WalletStatsViewModel
ViewModels/Wallets/ClosedHardwareWalletViewModel
ViewModels/Wallets/ClosedWalletViewModel
ViewModels/Wallets/ClosedWatchOnlyWalletViewModel
ViewModels/Wallets/CoinJoinSettingsViewModel
ViewModels/Wallets/HardwareWalletViewModel
ViewModels/Wallets/Home/History/Details/CoinJoinDetailsViewModel
ViewModels/Wallets/Home/History/Details/CoinJoinsDetailsViewModel
ViewModels/Wallets/Home/History/Details/TransactionDetailsViewModel
ViewModels/Wallets/Home/Tiles/PrivacyRing/PrivacyRingViewModel
ViewModels/Wallets/Receive/AddressLabelEditViewModel
ViewModels/Wallets/Receive/ReceiveAddressViewModel
ViewModels/Wallets/Receive/ReceiveAddressesViewModel
ViewModels/Wallets/Receive/ReceiveViewModel
ViewModels/Wallets/Send/CustomFeeRateDialogViewModel
ViewModels/Wallets/Send/PrivacyControlViewModel
ViewModels/Wallets/Send/SendFeeViewModel
ViewModels/Wallets/Send/SendSuccessViewModel
ViewModels/Wallets/Send/SendViewModel
ViewModels/Wallets/Send/TransactionPreviewViewModel
ViewModels/Wallets/VerifyRecoveryWordsViewModel
ViewModels/Wallets/WalletSettingsViewModel
ViewModels/Wallets/WalletViewModel
ViewModels/Wallets/WalletViewModelBase
ViewModels/Wallets/WatchOnlyWalletViewModel