Don't include Bevy default features when used as a dependency. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, this plugin pulls in dependencies for Bevy features I don't need when used as a plugin (E.g. the audio feature is enabled even though neither I nor this plugin require it.) All features are re-enabled in `[dev-dependencies]` so examples are unconstrained.
zkat
approved these changes
Jun 2, 2021
payload
pushed a commit
to payload/big-brain
that referenced
this pull request
Sep 16, 2021
…ncy. (zkat#25) Without this change, this plugin pulls in dependencies for Bevy features I don't need when used as a plugin (E.g. the audio feature is enabled even though neither I nor this plugin require it.) All features are re-enabled in `[dev-dependencies]` so examples are unconstrained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, this plugin pulls in dependencies for Bevy features I don't need when used as a plugin (E.g. the audio feature is enabled even though neither I nor this plugin require it.) All features are re-enabled in
[dev-dependencies]so examples are unconstrained.