Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related lib reflink has important fix merged but seems it's not going to be released #46

Closed
shandak opened this issue Apr 25, 2023 · 5 comments · Fixed by #55
Closed

Comments

@shandak
Copy link

shandak commented Apr 25, 2023

The related lib reflink is quite old and has a bug described there nicokoch/reflink#4 so the same issue happens when I'm using cacache too. Would not be a problem for you to bump dependency like there bczhc/rust@e9df2ba to the master branch?

@zkat
Copy link
Owner

zkat commented Apr 25, 2023

unfortunately, I can't publish git dependencies to crates.io, so the only way I would be able to do this is if a "forked" version of reflink with the patch applied were published to crates.io, or the original author actually releasing a new version.

@shandak
Copy link
Author

shandak commented May 2, 2023

I did a fix like that in Cargo.toml

[replace]
ttps://github.com/nicokoch/reflink/issues/4
"reflink:0.1.3" = { git = "https://github.com/nicokoch/reflink", rev = "e8d93b46" }

@shandak shandak closed this as completed May 2, 2023
@jakubadamw
Copy link

I'd honestly reconsider depending on that package. It's not being maintained.

@zkat zkat reopened this Jun 29, 2023
@zkat
Copy link
Owner

zkat commented Jun 29, 2023

I'd like to keep this open, since it's definitely still an issue.

I'd love to get rid of this as a dependency, but reflink is a pretty nontrivial package, and I want access to the functionality it's providing.

CommanderStorm added a commit to TUM-Dev/NavigaTUM that referenced this issue Jul 7, 2023
@06chaynes
Copy link
Sponsor Contributor

06chaynes commented Aug 1, 2023

It looks like there is a maintained fork here:
https://github.com/cargo-bins/reflink-copy
https://crates.io/crates/reflink-copy

Edit: Created a PR here if interested: #55

@zkat zkat linked a pull request Sep 5, 2023 that will close this issue
@zkat zkat closed this as completed in #55 Sep 11, 2023
zkat pushed a commit that referenced this issue Sep 11, 2023
zkat pushed a commit that referenced this issue Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants