cipm causes frightening bluebird warnings when using npm ci

[jehy]

There are several places in cipm when an object is being passed to .then() in bluebird promise chain.
It works but it causes warning message as described here: https://github.com/petkaantonov/bluebird/blob/master/docs/docs/warning-explanations.md

So using npm ci creates a long warning stack with messages like

(node:21662) Warning: .then() only accepts functions but was passed: [object Object]

Everything still works but that's very frightening and I think that it is important to fix this warning and ask npm to bump cipm version. I will add pull request here in several minutes.

[benjamingr]

Warning appears to be a true positive in this case.

[jehy]

@zkat please take a look, it is very inconvenient to see a hundred of those warnings on every install.

[benjamingr]

@jehy you opened an issue (less than a week ago) on a repository Kat maintains and coded you find useful. I think a "please take a look quickly" is unwarranted for.

Please consider that when you post follow ups like this can demotivate people from actually wanting to help. From my interactions with her Kat has very thick skin and probably doesn't mind (and is of course very capable of speaking for herself) - but that doesn't mean it's a very welcome way to interact.

If you really care about swift handling you can:

• Make a pull request for the change here.
  • Ask how to contribute if you're not sure how.
• Pay someone to make a pull request for the change in.
• Offer to pay a current maintainer to take a look.
• Ask others in a JavaScript community for help.

Sorry if my comment is coming off as annoying - I have nothing against you and this sort of response is pretty common - I'm only attempting to help with what sort of interactions generally work better in my experience.

[jehy]

@benjamingr oh, sorry, I did not mean to be rude. I wrote this issue, PR and comments while working, and I was really short on time then. Also, English is not my native language.

Really sorry if I was rude in conversation. By the way, I already made a PR (#59). I just worry that now many people are migrating to node 10 and they will have bad experience. And I really love node.

[benjamingr]

Thanks for the contribution, I'm sure Kat will look into it when she has time :)

[mearns]

Thank you @jehy and @zkat for the fix. It doesn't appear to be released yet (as f npm v6.9.0, I still get this warning on npm ci). Any idea when this will be released?

Thanks!