Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of MillerLoopResult independently of the builtin apis #67

Closed
Tracked by #43
dignifiedquire opened this issue Jul 20, 2021 · 2 comments · Fixed by #71
Closed
Tracked by #43

Allow usage of MillerLoopResult independently of the builtin apis #67

dignifiedquire opened this issue Jul 20, 2021 · 2 comments · Fixed by #71

Comments

@dignifiedquire
Copy link
Contributor

In the former implementation of pairing it was possible to use Fp12 directly to work with the intermediary results of miller loops, before doing the final accumulation. With the new API of MillerLoopResult and Gt this is impossible.

You can see an example of this here: https://github.com/filecoin-project/bls-signatures/blob/master/src/signature.rs#L158-L208, which I am trying to migrate to this crate.

@dignifiedquire
Copy link
Contributor Author

Actually most of it is possible, I am just missing a way to create an empty MillerLoopResult I realized, so just implementing Default for it would probably be enough for my use case.

@str4d
Copy link
Member

str4d commented Aug 16, 2021

Yeah, impl Default for MillerLoopResult seems reasonable to me. Though now that Iterator::reduce is available (which doesn't require an initial accumulator value), is this necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants