Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up network generation #319

Merged
merged 13 commits into from Oct 5, 2023
Merged

Speed up network generation #319

merged 13 commits into from Oct 5, 2023

Conversation

zktuong
Copy link
Owner

@zktuong zktuong commented Oct 4, 2023

found a few places that sped up the creation of the networks.
added new options to toggle to tl.generate network

expanded_only: bool = False # whether to only generate the layout for the expanded slot.

use_existing_graph: bool = True # whether to skip the computing of edges and just use the graph that is already computed to regenerate the layout.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #319 (9201d88) into master (d63b2f0) will increase coverage by 0.05%.
The diff coverage is 93.66%.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   82.96%   83.01%   +0.05%     
==========================================
  Files          47       47              
  Lines        8520     8551      +31     
==========================================
+ Hits         7069     7099      +30     
- Misses       1451     1452       +1     
Flag Coverage Δ
unittests 83.01% <93.66%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dandelion/utilities/_utilities.py 84.98% <ø> (-0.13%) ⬇️
tests/test_mouse.py 100.00% <100.00%> (ø)
dandelion/tools/_network.py 75.80% <93.33%> (+1.06%) ⬆️

@zktuong zktuong merged commit bf15aed into master Oct 5, 2023
16 checks passed
@zktuong zktuong deleted the speed-up-network-generation branch November 3, 2023 04:06
@zktuong
Copy link
Owner Author

zktuong commented Nov 22, 2023

some breaking changes here. need to revert . going to try and restore this through #336 and #335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant