Ignore some roads for the editor #66
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an implicit no parking (or even no stopping?) on emergency_access.
This function was not used anymore.
In getUrl(), the option to use overpass is only given in viewerMode. But the Fetch options dropdown suggests is can be used in both modes. With this change, the dropdown is hidden unless it actually does something. WIP => However, this solution feels too hacky to use this way. I had to remove and re-add the fetch controls in order to get a re-render going. Is there a nicer way to do this?
Some service roads and roads without access should not be visible in the editor UI. This will filter those roads.
|
I will leave this as draft, since it's not merge-ready but it would be great to get some feedback on the questions in 'Update 2'. |
|
Road filtering must be here https://github.com/zlant/parking-lanes/blob/master/src/parking/interface.ts#L175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the following roads will be ignored when loading data for the editor:
service=emergency_accessservice=parking_aisleservice=drivewayaccess=privateAt least for Berlin, there should never be parking data needed for those roads, since they are implicitly no parking.
Is this the same where you are mapping? If not, I would change this PR to move those configuration in a local settings file per country.
Update: Converted to draft
I am not sure anymore this change actually does what I want it to do. I would still love to year your feedback on the general idea (and maybe config), but will update here once I know that this is working.
Update 2: The codes does what I want it to do now.
The question is, though, if this is nice enough to be used.
A new feature in this branch is c35e826 => What would be a clean way to re-render the dropdown? Or how could this code be refactored to fit into the style of the app? – Or should I remove it again?
3e273e6 filters the roads described above. => Is this approach OK?
Also, I would love to learn how the data fetching actually works with the osm.org API. Where does the script specify the condition of which data is included? (Like the overpass query did.)