Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore some roads for the editor #66

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Ignore some roads for the editor #66

wants to merge 6 commits into from

Commits on Feb 2, 2022

  1. Ignore private roads, driveways for editor

    @tordans
    tordans committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    4e12374 View commit details
    Browse the repository at this point in the history

  2. Ignore emergency_access 

    There is an implicit no parking (or even no stopping?) on emergency_access.
    @tordans
    tordans committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    1b292c7 View commit details
    Browse the repository at this point in the history

  3. Remove getOverpassEditorQuery() 

    This function was not used anymore.
    @tordans
    tordans committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    6c4e3d5 View commit details
    Browse the repository at this point in the history

  4. Refactoring: Mark unused variables with underscore

    @tordans
    tordans committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    ce39d3c View commit details
    Browse the repository at this point in the history

  5. [WIP] UI: Show fetch options dropdown only when feasible 

    In getUrl(), the option to use overpass is only given in viewerMode. But the Fetch options dropdown suggests is can be used in both modes.

With this change, the dropdown is hidden unless it actually does something.

WIP => However, this solution feels too hacky to use this way. I had to remove and re-add the fetch controls in order to get a re-render going. Is there a nicer way to do this?
    @tordans
    tordans committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    c35e826 View commit details
    Browse the repository at this point in the history

  6. parseOsmResp: Exclude certain roads 

    Some service roads and roads without access should not be visible in the editor UI. This will filter those roads.
    @tordans
    tordans committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    3e273e6 View commit details
    Browse the repository at this point in the history