Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MZ_VERSION_BUILD became an octal number in 3.0.0, that becomes invalid with certain version numbers #758

Closed
progician opened this issue Jan 4, 2024 · 3 comments
Labels
api Interface changes

Comments

@progician
Copy link

I was using OCIO with minizip-ng 3.0.9, and it broke the compilation with this error message:

/path/to/OpenColorIO/src/OpenColorIO/OCIOZArchive.cpp:530:5: error: invalid digit '9' in octal constant
#if MZ_VERSION_BUILD >= 040000
    ^
/path/to/minizip-ng/include/mz.h:18:47: note: expanded from macro 'MZ_VERSION_BUILD'
#define MZ_VERSION_BUILD                (030009)

Looking at the history of the project, since the version bump to 3.0.0, the problem exists:

6f17da5

As you can see, the diff shows that the version number went from 21006 (decimal) to 030000 (octal) which is a net reduction of the version number in the first place because 030000 octal is 12288 in decimal.

Later, we see the use of 'a' for the digit 10, which suggests that the true number you want to generate is a hexadecimal number. Would you mind fixing your processes?

@nmoinvaz nmoinvaz added the api Interface changes label Jan 4, 2024
@nmoinvaz
Copy link
Member

nmoinvaz commented Jan 4, 2024

Thanks. I have added 0x prefix to it.

@nmoinvaz nmoinvaz closed this as completed Jan 4, 2024
@progician
Copy link
Author

Thanks, that was really, really quick 👍🏻

@opoplawski
Copy link

It seems like it could also have been changed to 30010 and 40004. If sticking with hex, it seems like a new release of 3.X with the hex version might be in order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Interface changes
Projects
None yet
Development

No branches or pull requests

3 participants