Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of bugs on windows caught by AppVerifier
mz_crypt_pbkdf2(..)
,CryptDeleteHash
was being called after the associated Crypt context was releasedmz_crypt_hmac_init
, so they each get their own context (provider) from theCryptAcquireContext(..)
functionmz_crypt_hmac_copy
, which creates a duplicate of hmac2's hash, sharing the same contextCryptReleaseContext
. The subsequent call toCryptDestroyHash(..)
on hmac3's hash would lead to UB as the associated context has already been released by that pointmz_crypt_hmac_delete(..)
on hmac3 first, so that the contexts are cleared at the end after the hashes are destroyed.mz_crypt_hmac_copy
, iftarget->hash
already contained a hash prior to the function being called, that hash would be overwritten, withoutCryptDestroyHash
being called on it.target->hash
is non-empty inmz_crypt_hmac_copy
and callCryptDestroyHash
on it