Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use __has_include instead of preprocessor defines. #484

Merged
merged 2 commits into from Jun 7, 2020
Merged

Use __has_include instead of preprocessor defines. #484

merged 2 commits into from Jun 7, 2020

Conversation

triplef
Copy link
Contributor

@triplef triplef commented May 29, 2020

As discussed this lets the compiler check for header availability.

I left the checks for HAVE_STDINT_H and HAVE_INTTYPES_H in CMakeLists, as they still seem to be used in liblzma.

@nmoinvaz
Copy link
Member

nmoinvaz commented Jun 6, 2020

@triplef can you confirm my change works for you still?

@nmoinvaz nmoinvaz changed the base branch from master to dev June 7, 2020 01:37
@nmoinvaz nmoinvaz merged commit b6bbb9f into zlib-ng:dev Jun 7, 2020
@nmoinvaz
Copy link
Member

nmoinvaz commented Jun 7, 2020 •
edited

Merged into dev branch. Thanks!

@triplef triplef deleted the use-has-include branch June 7, 2020 09:02
@triplef
Copy link
Contributor Author

triplef commented Jun 7, 2020

Thank you. This works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@triplef @nmoinvaz