mz_compat: support unzGetCurrentFileInfo without pfile_info #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow getting filename/extrafield/comment separately without specifying an unz_file_info structure to improve compatibility with minizip1.
nmoinvaz
reviewed
Dec 3, 2020
mz_compat.c
Outdated
| @@ -606,8 +606,9 @@ int unzGetCurrentFileInfo(unzFile file, unz_file_info *pfile_info, char *filenam | |||
| return UNZ_PARAMERROR; | |||
|
|
|||
| err = mz_zip_entry_get_info(compat->handle, &file_info); | |||
| if (err != MZ_OK) return err; | |||
|
Thanks for the pull request. Can you also make similar changes to |
…well Moved return statement to separate line. Applied the same changes to unzGetCurrentFileInfo64 (allow getting filename/comment/extrafield separately without unz_file_info64)
|
Looks good! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow getting filename/extrafield/comment separately without specifying an unz_file_info structure to improve compatibility with minizip1.
Fixes issue #535.