Create parent directory before extracting symlink #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-conder-sm
force-pushed
the
master
branch
from
7b68f0a
to
eca119e
Compare
nmoinvaz
reviewed
Mar 11, 2023
jonathan-conder-sm
force-pushed
the
master
branch
from
eca119e
to
34c699e
Compare
At least when using Info-ZIP 3.0, symlinks to both files and directories lack a trailing slash, so the second mz_path_remove_filename is unnecessary (and could break things if the parent directory doesn't precede the symlink in the file). If other implementations do add a trailing slash, the if statement should handle that.
jonathan-conder-sm
force-pushed
the
master
branch
from
34c699e
to
277b858
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least when using Info-ZIP 3.0, symlinks to both files and directories lack a trailing slash, so the second mz_path_remove_filename is unnecessary (and could break things if the parent directory doesn't precede the symlink in the file). If other implementations do add a trailing slash, the if statement should handle that.