Use POSIX implementation if platform is not Windows #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are conflicts with develop branch. |
lawadr
force-pushed
the
platform-fallthrough-fix
branch
from
72f5ee9
to
d6aad1c
Compare
Non-UNIX platforms may support POSIX, partly or fully, through a compatibility layer of some kind. If a non-Windows platform does not have the UNIX CMake variable set, take the POSIX path through the CMake anyway.
lawadr
force-pushed
the
platform-fallthrough-fix
branch
from
d6aad1c
to
984b434
Compare
nmoinvaz
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-UNIX platforms may support POSIX, partly or fully, through a compatibility layer of some kind. If a non-Windows platform does not have the UNIX CMake variable set, take the POSIX path through the CMake anyway.
Previously, for platforms without the WIN32 or UNIX variables set, the binaries would fail to link due to missing
mz_strm_os_*.candmz_os_*.cimplementations. This change opens up POSIX support for platforms that fall through the crack without changing any logic for platforms that could previously be built for.