Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake install location #704

Merged
merged 1 commit into from Jun 8, 2023

Conversation

kschwarz-intrepidcs
Copy link
Contributor

@kschwarz-intrepidcs kschwarz-intrepidcs commented Jun 2, 2023

CMake's find_package() will search these paths when attempting to find a package config (note that while CMake's docs appear to indicate that <name> is optional (*) it's actually required):

<prefix>/
<prefix>/(cmake|CMake)/
<prefix>/<name>*/
<prefix>/<name>*/(cmake|CMake)/
<prefix>/<name>*/(cmake|CMake)/<name>*/
<prefix>/(lib/<arch>|lib*|share)/cmake/<name>*/
<prefix>/(lib/<arch>|lib*|share)/<name>*/
<prefix>/(lib/<arch>|lib*|share)/<name>*/(cmake|CMake)/
<prefix>/<name>*/(lib/<arch>|lib*|share)/cmake/<name>*/
<prefix>/<name>*/(lib/<arch>|lib*|share)/<name>*/
<prefix>/<name>*/(lib/<arch>|lib*|share)/<name>*/(cmake|CMake)/

The current minizip-ng config install location of <prefix>/lib*/cmake/minizip-config.cmake will not be found because the config is expected to be in a minizip subdirectory under cmake.

This can be tested with:

set(CMAKE_PREFIX_PATH "/tmp/a1f568d6/install;/tmp/95d43940/install")

find_package(minizip CONFIG REQUIRED)

message("${minizip_DIR}")

@nmoinvaz nmoinvaz changed the base branch from master to develop June 7, 2023 16:56
@nmoinvaz nmoinvaz added the build system Build system and script changes label Jun 7, 2023
@nmoinvaz nmoinvaz merged commit 382335a into zlib-ng:develop Jun 8, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system Build system and script changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants