Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small buildfixes #1348

Merged
merged 5 commits into from
Oct 9, 2022
Merged

Various small buildfixes #1348

merged 5 commits into from
Oct 9, 2022

Conversation

Dead2
Copy link
Member

@Dead2 Dead2 commented Sep 14, 2022

Found various small issues while doing a lot of manual testing with Clang and Stabilizer

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 83.87% // Head: 83.22% // Decreases project coverage by -0.65% ⚠️

Coverage data is based on head (1945c9e) compared to base (d38dd92).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1348      +/-   ##
===========================================
- Coverage    83.87%   83.22%   -0.66%     
===========================================
  Files          126      127       +1     
  Lines        10544    10628      +84     
  Branches      2706     2713       +7     
===========================================
+ Hits          8844     8845       +1     
- Misses        1034     1116      +82     
- Partials       666      667       +1     
Flag Coverage Δ
macos_clang 41.94% <ø> (ø)
macos_gcc 73.09% <ø> (-0.72%) ⬇️
ubuntu_clang 83.66% <ø> (-0.03%) ⬇️
ubuntu_clang_debug 83.26% <ø> (-0.17%) ⬇️
ubuntu_clang_inflate_allow_invalid_dist 83.31% <ø> (-0.20%) ⬇️
ubuntu_clang_inflate_strict 82.63% <ø> (-1.22%) ⬇️
ubuntu_clang_mmap 82.96% <ø> (-1.23%) ⬇️
ubuntu_clang_pigz 39.44% <ø> (-0.65%) ⬇️
ubuntu_clang_pigz_no_optim 41.49% <ø> (ø)
ubuntu_clang_pigz_no_threads 39.04% <ø> (-0.64%) ⬇️
ubuntu_clang_reduced_mem 84.15% <ø> (-0.21%) ⬇️
ubuntu_gcc 74.96% <ø> (-0.69%) ⬇️
ubuntu_gcc_aarch64 77.40% <ø> (ø)
ubuntu_gcc_aarch64_compat_no_opt 75.57% <ø> (+0.01%) ⬆️
ubuntu_gcc_aarch64_no_acle 76.12% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 76.12% <ø> (ø)
ubuntu_gcc_armhf 77.35% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 75.40% <ø> (ø)
ubuntu_gcc_armhf_no_acle 77.37% <ø> (ø)
ubuntu_gcc_armhf_no_neon 77.27% <ø> (ø)
ubuntu_gcc_armsf 77.17% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 75.34% <ø> (+0.01%) ⬆️
ubuntu_gcc_benchmark 73.86% <ø> (-0.29%) ⬇️
ubuntu_gcc_compat_no_opt 76.96% <ø> (ø)
ubuntu_gcc_compat_sprefix 73.78% <ø> (-0.30%) ⬇️
ubuntu_gcc_m32 73.88% <ø> (+0.15%) ⬆️
ubuntu_gcc_mingw_i686 0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <ø> (ø)
ubuntu_gcc_no_avx2 74.85% <ø> (+0.12%) ⬆️
ubuntu_gcc_no_ctz 74.94% <ø> (ø)
ubuntu_gcc_no_ctzll 74.96% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 73.96% <ø> (ø)
ubuntu_gcc_no_sse2 74.19% <ø> (-0.69%) ⬇️
ubuntu_gcc_no_sse4 74.62% <ø> (+0.06%) ⬆️
ubuntu_gcc_o1 73.76% <ø> (-0.73%) ⬇️
ubuntu_gcc_osb ∅ <ø> (∅)
ubuntu_gcc_pigz 37.71% <ø> (-0.26%) ⬇️
ubuntu_gcc_pigz_aarch64 39.07% <ø> (+0.11%) ⬆️
ubuntu_gcc_ppc 73.70% <ø> (ø)
ubuntu_gcc_ppc64 74.57% <ø> (ø)
ubuntu_gcc_ppc64le 74.51% <ø> (ø)
ubuntu_gcc_ppc_no_power8 74.64% <ø> (ø)
ubuntu_gcc_s390x 74.96% <ø> (ø)
ubuntu_gcc_s390x_dfltcc 72.18% <ø> (ø)
ubuntu_gcc_s390x_dfltcc_compat 73.72% <ø> (ø)
ubuntu_gcc_s390x_no_crc32 74.75% <ø> (ø)
ubuntu_gcc_sparc64 74.86% <ø> (ø)
ubuntu_gcc_sprefix 74.04% <ø> (+0.29%) ⬆️
win64_gcc 74.24% <ø> (+0.12%) ⬆️
win64_gcc_compat_no_opt 74.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arch/x86/crc32_fold_pclmulqdq_tpl.h 91.74% <0.00%> (-7.26%) ⬇️
fallback_builtins.h 92.59% <0.00%> (ø)
arch/x86/crc32_fold_vpclmulqdq_tpl.h 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

configure Outdated Show resolved Hide resolved
@Dead2 Dead2 merged commit 9b9be8b into develop Oct 9, 2022
@Dead2 Dead2 mentioned this pull request Dec 27, 2022
Dead2 added a commit that referenced this pull request Mar 7, 2023
Changes since 2.0.6:
- Fix CVE-2022-37434 #1328
- Fix chunkmemset #1196
- Fix deflateBound too small #1236
- Fix Z_SOLO #1263
- Fix ACLE variant of crc32 #1274
- Fix inflateBack #1311
- Fix deflate_quick windowsize #1431
- Fix DFLTCC bugs related to adler32 #1349 and #1390
- Fix warnings #1194 #1312 #1362
- MacOS build fix #1198
- Add invalid windowBits handling #1293
- Support for Force TZCNT #1186
- Support for aligned_alloc() #1360
- Minideflate improvements #1175 #1238
- Dont use unaligned access for memcpy #1309
- Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365
- Test improvements #1208 #1227 #1241 #1353
- Cleanup #1266
- Documentation #1205 #1359
- Misc improvements #1294 #1297 #1306 #1344 #1348
- Backported zlib fixes
- Backported CI workflows from Develop branch
Dead2 added a commit that referenced this pull request Mar 17, 2023
Changes since 2.0.6:
- Fix CVE-2022-37434 #1328
- Fix chunkmemset #1196
- Fix deflateBound too small #1236
- Fix Z_SOLO #1263
- Fix ACLE variant of crc32 #1274
- Fix inflateBack #1311
- Fix deflate_quick windowsize #1431
- Fix DFLTCC bugs related to adler32 #1349 and #1390
- Fix warnings #1194 #1312 #1362
- MacOS build fix #1198
- Add invalid windowBits handling #1293
- Support for Force TZCNT #1186
- Support for aligned_alloc() #1360
- Minideflate improvements #1175 #1238
- Dont use unaligned access for memcpy #1309
- Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365
- Test improvements #1208 #1227 #1241 #1353
- Cleanup #1266
- Documentation #1205 #1359
- Misc improvements #1294 #1297 #1306 #1344 #1348
- Backported zlib fixes
- Backported CI workflows from Develop branch
@Dead2 Dead2 deleted the buildfixes branch April 16, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants