Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable redirection to 64-bit function variants when Z_SOLO is defined #1263

Merged
merged 1 commit into from
May 3, 2022

Conversation

mtl1979
Copy link
Collaborator

@mtl1979 mtl1979 commented May 3, 2022

See #1262.

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #1263 (dd62922) into develop (84f116a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1263   +/-   ##
========================================
  Coverage    87.40%   87.40%           
========================================
  Files          114      114           
  Lines        10164    10164           
  Branches      2554     2554           
========================================
  Hits          8884     8884           
+ Misses         957      956    -1     
- Partials       323      324    +1     
Flag Coverage Δ
macos_clang 30.95% <ø> (ø)
macos_gcc 74.98% <ø> (ø)
ubuntu_clang 87.42% <ø> (ø)
ubuntu_clang_debug 86.96% <ø> (+0.81%) ⬆️
ubuntu_clang_inflate_allow_invalid_dist 87.12% <ø> (+0.85%) ⬆️
ubuntu_clang_inflate_strict 87.37% <ø> (ø)
ubuntu_clang_mmap 87.56% <ø> (+0.85%) ⬆️
ubuntu_clang_pigz 40.95% <ø> (ø)
ubuntu_clang_pigz_no_optim 41.14% <ø> (ø)
ubuntu_clang_pigz_no_threads 40.53% <ø> (ø)
ubuntu_clang_reduced_mem 87.82% <ø> (ø)
ubuntu_gcc 77.06% <ø> (ø)
ubuntu_gcc_aarch64 77.37% <ø> (ø)
ubuntu_gcc_aarch64_compat_no_opt 75.47% <ø> (ø)
ubuntu_gcc_aarch64_no_acle 76.27% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 76.16% <ø> (ø)
ubuntu_gcc_armhf 77.38% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 75.39% <ø> (ø)
ubuntu_gcc_armhf_no_acle 77.40% <ø> (ø)
ubuntu_gcc_armhf_no_neon 77.16% <ø> (ø)
ubuntu_gcc_armsf 77.25% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 75.06% <ø> (ø)
ubuntu_gcc_benchmark 74.62% <ø> (-0.38%) ⬇️
ubuntu_gcc_compat_no_opt 76.60% <ø> (ø)
ubuntu_gcc_compat_sprefix 75.10% <ø> (+0.38%) ⬆️
ubuntu_gcc_m32 74.45% <ø> (-0.39%) ⬇️
ubuntu_gcc_mingw_i686 0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <ø> (ø)
ubuntu_gcc_no_avx2 76.72% <ø> (ø)
ubuntu_gcc_no_ctz 74.76% <ø> (ø)
ubuntu_gcc_no_ctzll 74.79% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 75.51% <ø> (ø)
ubuntu_gcc_no_sse2 76.79% <ø> (+0.76%) ⬆️
ubuntu_gcc_no_sse4 75.56% <ø> (ø)
ubuntu_gcc_o1 76.03% <ø> (ø)
ubuntu_gcc_osb ∅ <ø> (∅)
ubuntu_gcc_pigz 38.90% <ø> (ø)
ubuntu_gcc_pigz_aarch64 39.29% <ø> (-0.03%) ⬇️
ubuntu_gcc_ppc 73.81% <ø> (ø)
ubuntu_gcc_ppc64 74.56% <ø> (ø)
ubuntu_gcc_ppc64le 74.53% <ø> (ø)
ubuntu_gcc_ppc_no_power8 74.73% <ø> (ø)
ubuntu_gcc_s390x 74.73% <ø> (ø)
ubuntu_gcc_s390x_dfltcc 72.09% <ø> (ø)
ubuntu_gcc_s390x_dfltcc_compat 73.70% <ø> (ø)
ubuntu_gcc_s390x_no_crc32 74.51% <ø> (ø)
ubuntu_gcc_sparc64 74.62% <ø> (ø)
ubuntu_gcc_sprefix 74.50% <ø> (ø)
win64_gcc 73.95% <ø> (ø)
win64_gcc_compat_no_opt 74.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gzlib.c 71.10% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f116a...dd62922. Read the comment docs.

@mtl1979 mtl1979 force-pushed the sololfs branch 3 times, most recently from 6ccde43 to ef6dec6 Compare May 3, 2022 01:21
@mtl1979
Copy link
Collaborator Author

mtl1979 commented May 3, 2022

@nmoinvaz @Dead2

Only failing test is due to DNS error...

@pmqs
Copy link
Contributor

pmqs commented May 3, 2022

@mtl1979 this change fixed the issues I was seeing in #1262

@Dead2 Dead2 merged commit 4422a6b into zlib-ng:develop May 3, 2022
@Dead2 Dead2 mentioned this pull request Dec 27, 2022
Dead2 added a commit that referenced this pull request Mar 7, 2023
Changes since 2.0.6:
- Fix CVE-2022-37434 #1328
- Fix chunkmemset #1196
- Fix deflateBound too small #1236
- Fix Z_SOLO #1263
- Fix ACLE variant of crc32 #1274
- Fix inflateBack #1311
- Fix deflate_quick windowsize #1431
- Fix DFLTCC bugs related to adler32 #1349 and #1390
- Fix warnings #1194 #1312 #1362
- MacOS build fix #1198
- Add invalid windowBits handling #1293
- Support for Force TZCNT #1186
- Support for aligned_alloc() #1360
- Minideflate improvements #1175 #1238
- Dont use unaligned access for memcpy #1309
- Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365
- Test improvements #1208 #1227 #1241 #1353
- Cleanup #1266
- Documentation #1205 #1359
- Misc improvements #1294 #1297 #1306 #1344 #1348
- Backported zlib fixes
- Backported CI workflows from Develop branch
Dead2 added a commit that referenced this pull request Mar 17, 2023
Changes since 2.0.6:
- Fix CVE-2022-37434 #1328
- Fix chunkmemset #1196
- Fix deflateBound too small #1236
- Fix Z_SOLO #1263
- Fix ACLE variant of crc32 #1274
- Fix inflateBack #1311
- Fix deflate_quick windowsize #1431
- Fix DFLTCC bugs related to adler32 #1349 and #1390
- Fix warnings #1194 #1312 #1362
- MacOS build fix #1198
- Add invalid windowBits handling #1293
- Support for Force TZCNT #1186
- Support for aligned_alloc() #1360
- Minideflate improvements #1175 #1238
- Dont use unaligned access for memcpy #1309
- Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365
- Test improvements #1208 #1227 #1241 #1353
- Cleanup #1266
- Documentation #1205 #1359
- Misc improvements #1294 #1297 #1306 #1344 #1348
- Backported zlib fixes
- Backported CI workflows from Develop branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants