Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on OpenBSD #1466

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Fix compilation on OpenBSD #1466

merged 1 commit into from
Apr 15, 2023

Conversation

riscygeek
Copy link
Contributor

On OpenBSD for Non-POSIX functions (like vasprintf() and swap16()) to be defined,
it requires defining _BSD_SOURCE.

Otherwise the build fails to compile, or compiles successfully and fails when linking against zlib-ng.

Non-POSIX functions (like vasprintf() and swap16()) require
_BSD_SOURCE to be defined.

Signed-off-by: Benjamin Stürz <benni@stuerz.xyz>
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (c4c1c7f) 83.15% compared to head (2dbae15) 83.12%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1466      +/-   ##
===========================================
- Coverage    83.15%   83.12%   -0.03%     
===========================================
  Files          130      130              
  Lines        10759    10675      -84     
  Branches      2760     2739      -21     
===========================================
- Hits          8947     8874      -73     
+ Misses        1136     1135       -1     
+ Partials       676      666      -10     
Flag Coverage Δ
macos_clang 42.97% <ø> (ø)
macos_gcc 72.97% <ø> (ø)
ubuntu_clang 82.25% <ø> (ø)
ubuntu_clang_debug 81.92% <ø> (ø)
ubuntu_clang_inflate_allow_invalid_dist 81.91% <ø> (ø)
ubuntu_clang_inflate_strict 82.24% <ø> (ø)
ubuntu_clang_mmap 82.34% <ø> (-0.23%) ⬇️
ubuntu_clang_pigz 14.15% <ø> (+0.05%) ⬆️
ubuntu_clang_pigz_no_optim 11.56% <ø> (ø)
ubuntu_clang_pigz_no_threads 13.97% <ø> (ø)
ubuntu_clang_reduced_mem 82.74% <ø> (+0.22%) ⬆️
ubuntu_gcc 74.49% <ø> (+0.07%) ⬆️
ubuntu_gcc_aarch64 76.66% <ø> (ø)
ubuntu_gcc_aarch64_compat_no_opt 75.00% <ø> (ø)
ubuntu_gcc_aarch64_no_acle 75.56% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 75.55% <ø> (ø)
ubuntu_gcc_armhf 76.74% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 74.97% <ø> (-0.02%) ⬇️
ubuntu_gcc_armhf_no_acle 76.69% <ø> (ø)
ubuntu_gcc_armhf_no_neon 76.57% <ø> (ø)
ubuntu_gcc_armsf 74.04% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 73.51% <ø> (ø)
ubuntu_gcc_benchmark 73.17% <ø> (ø)
ubuntu_gcc_compat_no_opt 76.07% <ø> (-0.02%) ⬇️
ubuntu_gcc_compat_sprefix 73.19% <ø> (+0.15%) ⬆️
ubuntu_gcc_m32 72.68% <ø> (ø)
ubuntu_gcc_mingw_i686 72.92% <ø> (-0.16%) ⬇️
ubuntu_gcc_mingw_x86_64 73.07% <ø> (ø)
ubuntu_gcc_no_avx2 73.65% <ø> (ø)
ubuntu_gcc_no_ctz 74.09% <ø> (ø)
ubuntu_gcc_no_ctzll 74.11% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 73.65% <ø> (ø)
ubuntu_gcc_no_sse2 73.81% <ø> (ø)
ubuntu_gcc_no_sse4 73.56% <ø> (ø)
ubuntu_gcc_o1 73.43% <ø> (-0.06%) ⬇️
ubuntu_gcc_osb ∅ <ø> (∅)
ubuntu_gcc_pigz 38.34% <ø> (-0.03%) ⬇️
ubuntu_gcc_pigz_aarch64 39.28% <ø> (+0.05%) ⬆️
ubuntu_gcc_ppc 73.32% <ø> (ø)
ubuntu_gcc_ppc64 73.78% <ø> (ø)
ubuntu_gcc_ppc64le 73.87% <ø> (ø)
ubuntu_gcc_ppc_no_power8 74.00% <ø> (ø)
ubuntu_gcc_s390x 74.19% <ø> (ø)
ubuntu_gcc_s390x_dfltcc 71.39% <ø> (ø)
ubuntu_gcc_s390x_dfltcc_compat ?
ubuntu_gcc_s390x_no_crc32 73.98% <ø> (ø)
ubuntu_gcc_sparc64 74.22% <ø> (ø)
ubuntu_gcc_sprefix 72.69% <ø> (-0.16%) ⬇️
win64_gcc 73.38% <ø> (+0.04%) ⬆️
win64_gcc_compat_no_opt 74.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Dead2 Dead2 merged commit e24334f into zlib-ng:develop Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants