[PPC64] Add support for gcc > 12 and clang > 12 #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mtl1979
commented
Jun 11, 2023
•
mtl1979
commented
- Use endianess-specific built-in function for gcc < 12 and clang
- Fix build with clang 13, 14, 15 and 16
- Fix detection for availability of Power9 intrinsics
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1520 +/- ##
===========================================
- Coverage 83.90% 82.85% -1.06%
===========================================
Files 132 133 +1
Lines 10848 10964 +116
Branches 2792 2823 +31
===========================================
- Hits 9102 9084 -18
- Misses 1046 1121 +75
- Partials 700 759 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mtl1979
changed the title
|
Hmm I feel like just bumping the gcc version here is not the best answer. I would like to know what gas is doing with {endian} in their intrinsic. Is it possible we just need to just use one of the two now? Given the intrinsic is supposed to give you the instruction it's thinly veiling I wouldn't love that but it makes some sense maybe. I'd also be curious what clang generates. |
The latest code is basically using just code that is equivalent to one of the intrinsics. The code would get really ugly if we test endianess later in the file just for gcc < 12. The "old" version didn't support compiling with clang, so there isn't anything to compare against... |
mtl1979
changed the title
mtl1979
changed the title
mtl1979
force-pushed
the
gcc13-ppc64le
branch
2 times, most recently
from
00ac94c
to
47d776a
Compare
mtl1979
changed the title
mtl1979
changed the title
mtl1979
force-pushed
the
gcc13-ppc64le
branch
8 times, most recently
from
14496b7
to
0c81bf8
Compare
* Add support for cross-compiling using clang 13 and later for PowerPC64 little-endian and big-endian * Fix detection for availability of Power9 intrinsics
Dead2
approved these changes
Jun 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.