Remove march=native support from Configure. #1555
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1555 +/- ##
===========================================
+ Coverage 83.87% 83.89% +0.01%
===========================================
Files 132 132
Lines 10843 10843
Branches 2801 2801
===========================================
+ Hits 9095 9097 +2
+ Misses 1049 1047 -2
Partials 699 699
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I don't have any problems with it. As you know I have been in favor of removing configure and nmake for a long time. 😆 |
Remove pkgcheck comparison of march=native builds between CMake and Configure.
Dead2
force-pushed
the
remove-configure-arch-native
branch
from
8de6d23
to
6756728
Compare
|
Makes absolutely no sense at all to remove features from configure script if we are going to remove whole configure script soon... Essentially we break testing "native" CMake build on CI. It makes more sense to make one big patch for the next major version that removes comparing CMake and configure builds and at the same time removes whole configure script. |
|
@mtl1979 We are not removing configure script.. |
Good as my Linux still has "too old" CMake version... |
|
@mtl1979 time to upgrade. Stop living in the past. 🤣 |
Can't upgrade work PC used for building binaries... Have to use oldest possible Linux version so it's compatible with all available releases... Can't use gcc 7 or later due to issue while compiling binaries that cause off by 8 in pointers. As everyone knows, gcc developers are more interested in making new releases than fixing bugs in existing ones. |
Dead2
changed the title
|
I would not remove the configure script, it only complicates bootstrapping. For example cmake needs zlib & curl, curl needs zlib & openssl, openssl needs zlib & perl (as build dep), perl needs zlib. |
This removes the partially broken march=native support from Configure.
CMake will still support this mode of compilation.
Compiling like this is an edge-case, and it is non-trivial to test, support and maintain with a codebase that supports many arch specific optimizations like ours. Removing this from Configure makes Configure simpler and easier to maintain, while letting us spend more effort on improving support in CMake.