Fix examining value of GENERATOR_IS_MULTI_CONFIG #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake does not define a variable GENERATOR_IS_MULTI_CONFIG by default. Instead it sets a global property of that name. In order to examine its value it first has to be retrieved and stored into a (local) variable, which is what this commit does. fixes: zlib-ng#1574 Signed-off-by: Deniz Bahadir <deniz@code.bahadir.email>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1575 +/- ##
===========================================
+ Coverage 83.88% 83.90% +0.01%
===========================================
Files 132 132
Lines 10843 10843
Branches 2801 2801
===========================================
+ Hits 9096 9098 +2
+ Misses 1048 1047 -1
+ Partials 699 698 -1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nmoinvaz
approved these changes
Sep 15, 2023
Dead2
approved these changes
Sep 15, 2023
DenizThatMenace
deleted the
bugfix/issue-1574/Fix_retrieving_GENERATOR_IS_MULTI_CONFIG
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake does not define a variable
GENERATOR_IS_MULTI_CONFIGby default. Instead it sets a global property of that name.In order to examine its value it first has to be retrieved and stored into a (local) variable, which is what this PR does.
fixes: #1574