Make sure inflateCopy() allocates window with the necessary buffer padding #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1583 +/- ##
========================================
Coverage 83.90% 83.91%
========================================
Files 133 133
Lines 10880 10873 -7
Branches 2805 2807 +2
========================================
- Hits 9129 9124 -5
Misses 1048 1048
+ Partials 703 701 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Dead2
force-pushed
the
inflatecopy-fix
branch
from
67fdd12
to
449178b
Compare
|
Looks ok to me. Alternatively, we could also just call: err = inflate_ensure_window(copy);
if (err != Z_OK) {
ZFREE_STATE(source, copy);
return err;
}
ZCOPY_WINDOW(copy->window, state->window, (size_t)1U << state->wbits); |
Dead2
force-pushed
the
inflatecopy-fix
branch
from
449178b
to
9050f7b
Compare
|
@nmoinvaz I agree, that would be cleaner. |
nmoinvaz
reviewed
Sep 25, 2023
Dead2
force-pushed
the
inflatecopy-fix
branch
from
9050f7b
to
513103b
Compare
|
As a bonus, this reduces text size quite a bit. Before: After: 224 bytes less to potentially pollute the cache 😄 |
nmoinvaz
approved these changes
Sep 26, 2023
|
Hmm, CI is failing. |
nmoinvaz
reviewed
Sep 26, 2023
Dead2
force-pushed
the
inflatecopy-fix
branch
from
513103b
to
0ec1c6d
Compare
nmoinvaz
reviewed
Sep 27, 2023
|
@iii-i I suspect this also affects DFLTCC systems, as |
…r chunked operations. Based on Chromium bugfix https://chromium-review.googlesource.com/c/chromium/src/+/4876445
Dead2
force-pushed
the
inflatecopy-fix
branch
from
0ec1c6d
to
a02e407
Compare
|
Hi, sorry, I somehow missed this. For what it's worth, the change looks good to me. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure inflateCopy() allocates window with the necessary buffer for chunked operations.
Based on Chromium bugfix https://chromium-review.googlesource.com/c/chromium/src/+/4876445