Fix deflate_state alignment with MS or clang-cl compilers

[pps83]

When building with clang-cl, compiler produces the following warning:

zlib-ng/deflate.h(287,3): warning : attribute 'align' is ignored, place it after "struct" to apply attribute to type declaration [-Wignored-attributes]
zlib-ng/zbuild.h(196,34): note: expanded from macro 'ALIGNED_'

Repositioning align attribute after "struct" fixes the warning and aligns deflate_state correctly.

[pps83]

Here's sample program showing that repositioning align attribute after "struct" doesn't affect alignment with g++:

https://coliru.stacked-crooked.com/a/cc7bafe2614a1b52

If you compile the same code with cl or clang-cl you'll see that align attribute placed at the end of the struct declaration has no effect. In my case, for example, I'm getting this output:

deflate_state1 align: 8
deflate_state2 align: 256

[nmoinvaz]

Did you check to see if any other struts suffer this same problem?

[pps83]

Did you check to see if any other struts suffer this same problem?

That's the only place, clang-cl has no other warnings also.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2049832) 83.24% compared to head (f387ac3) 83.24%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1663   +/-   ##
========================================
  Coverage    83.24%   83.24%           
========================================
  Files          135      135           
  Lines        10927    10927           
  Branches      2815     2815           
========================================
  Hits          9096     9096           
  Misses        1129     1129           
  Partials       702      702           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pps83]

Note, I added one more commit to increase alignment to 16 bytes. Fixing attribute made ms compiler understand the request and it started to complain:

3>D:\work-pps\backtest-engine\ext\zlib-ng\deflate.h(115,20): warning C4359: 'internal_state': Alignment specifier is less than actual alignment (16), and will be ignored.
3>(compiling source file '../ext/zlib-ng/zlib.cpp')

[pps83]

@Dead2 ping