-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and update NMake Makefiles. #1673
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1673 +/- ##
========================================
Coverage 83.03% 83.04%
========================================
Files 134 134
Lines 10336 10336
Branches 2813 2813
========================================
+ Hits 8583 8584 +1
Misses 1056 1056
+ Partials 697 696 -1 ☔ View full report in Codecov by Sentry. |
7beb848
to
5e10476
Compare
Did you make a script to do this or did you do it manually? |
I made an executable, I will make another PR/commit when I have integrated it to CI... |
I see. Or, if you want you can just make a GitHub gist and paste the code there. |
https://gist.github.com/mtl1979/83d0691c0c2a03154ffbea473a85a6c3 |
39a84a7
to
c0b07c1
Compare
@mtl1979 This needs a rebase |
@mtl1979 |
I run it from root of the repository using for example Running the check on Makefiles one by one is easier for a human than running |
917c511
to
9b535f0
Compare
|
* Add depcheck.exe to validate NMake Makefiles
$(TOP)
as NMake doesn't change directories while building,$(SRCDIR)
was redundant