Remove duplicated codecov parameter #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead, I think it should be renamed to |
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
|
@Dead2 Renamed. |
Dead2
approved these changes
Feb 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1684 +/- ##
========================================
Coverage 83.01% 83.01%
========================================
Files 135 135
Lines 10365 10365
Branches 2815 2815
========================================
Hits 8605 8605
+ Misses 1067 1063 -4
- Partials 693 697 +4 ☔ View full report in Codecov by Sentry. |
|
nit: Probably could use a better commit message, but otherwise LGTM. |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicated
codecovparameter.Bug appeared in PR #1662.