-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an inline asm fallback for the ARMv8 intrinsics #1697
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1697 +/- ##
========================================
Coverage 83.03% 83.04%
========================================
Files 134 134
Lines 10336 10336
Branches 2813 2813
========================================
+ Hits 8583 8584 +1
- Misses 1054 1057 +3
+ Partials 699 695 -4 ☔ View full report in Codecov by Sentry. |
Renaming ACLE to just ARMV8 is misleading... ARMv8 is a lot more than just ACLE CRC instructions. |
I'm not familar enough with ARM, why rename ACLE to ARMv8? |
ACLE is the name of the header for non-NEON intrinsics rather than a specific CPU extension. It's used for both ARMv8 CRC32 instructions and ARMv6 SIMD instructions, however the build system for zlib-ng only uses ARM_ACLE to refer to the ARMv8 code. The ARMv6 code uses a separate option. |
We can't just rename command-line options for |
Renaming should be split into a separate PR from the added features/fixes. |
The improved acle/armv8 check fixes a false positive when building for 32 bit arm iOS, I ripped out the improved check and put it in https://github.com/Un1q32/zlib-ng/tree/acle, I would make a PR with just that but I'll wait to see if the author of this PR finishes the main PR |
No activity here for a while, gonna make a PR for the bit I ripped out |
The configure checks have also been modified to better match the ARMv6 code.