Adjust cmake to install same .h and .pc files as configure #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #642 +/- ##
===========================================
- Coverage 78.02% 73.62% -4.41%
===========================================
Files 59 59
Lines 7282 7215 -67
Branches 1229 1215 -14
===========================================
- Hits 5682 5312 -370
- Misses 1111 1415 +304
+ Partials 489 488 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #642 +/- ##
===========================================
- Coverage 78.02% 73.54% -4.49%
===========================================
Files 59 59
Lines 7282 7242 -40
Branches 1229 1222 -7
===========================================
- Hits 5682 5326 -356
- Misses 1111 1427 +316
Partials 489 489
Continue to review full report at Codecov.
|
Dead2
reviewed
Jun 18, 2020
|
Other than the inline comment being misleading, the rest looks good to me. |
dankegel
force-pushed
the
bug638-same-pc-and-h
branch
from
c004009
to
41a8cf4
Compare
Codecov Report
@@ Coverage Diff @@
## develop #642 +/- ##
===========================================
- Coverage 79.19% 78.77% -0.42%
===========================================
Files 60 60
Lines 7464 7392 -72
Branches 1257 1248 -9
===========================================
- Hits 5911 5823 -88
- Misses 1048 1063 +15
- Partials 505 506 +1
Continue to review full report at Codecov.
|
dankegel
force-pushed
the
bug638-same-pc-and-h
branch
3 times, most recently
from
adcf34b
to
2e26d09
Compare
nmoinvaz
reviewed
Jun 18, 2020
dankegel
force-pushed
the
bug638-same-pc-and-h
branch
from
2e26d09
to
4121c4f
Compare
Also make comment in zconf.h less configure-specific
dankegel
force-pushed
the
bug638-same-pc-and-h
branch
from
4121c4f
to
293b444
Compare
|
The coverage failure seems spurious... some of the ppc jobs didn't run? |
…excluding .a and .so for now) Also add workflow to run pkgcheck.sh on one system.
dankegel
force-pushed
the
bug638-same-pc-and-h
branch
from
293b444
to
2a0cc77
Compare
|
I think this is ready to merge. |
nmoinvaz
approved these changes
Jun 19, 2020
The coverage comments are incomplete, you need to follow the #642 link in the comment, because on the website it is correct. This PR currently shows zero coverage change. Hopefully they will figure out what is wrong soon. |
|
Looks very good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first few commits of #639
They're the easy part of the fix for #638
The rest is touchier and deserves its own pull request (possibly after #560 lands)