Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed left shift ubsan warning in PULLBYTE. #789

Merged
merged 1 commit into from Oct 9, 2020

Conversation

nmoinvaz
Copy link
Member

@nmoinvaz nmoinvaz commented Oct 5, 2020

Mentioned in #784. Both PULLBYTE definitions should be the same now.

  infback.c:200:13: runtime error: left shift of 255 by 24 places cannot be represented in type 'int'
  624: SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/runner/work/zlib-ng/zlib-ng/infback.c:200:13 in

  infback.c:200:13: runtime error: left shift of 255 by 24 places cannot be represented in type 'int'
  624: SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/runner/work/zlib-ng/zlib-ng/infback.c:200:13 in
@nmoinvaz nmoinvaz added the bug label Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #789 into develop will decrease coverage by 2.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #789      +/-   ##
===========================================
- Coverage    73.40%   71.09%   -2.31%     
===========================================
  Files          127       57      -70     
  Lines        13801     7086    -6715     
  Branches      2525     1239    -1286     
===========================================
- Hits         10131     5038    -5093     
+ Misses        2629     1544    -1085     
+ Partials      1041      504     -537     
Flag Coverage Δ
#macos_clang ?
#macos_gcc ?
#ubuntu_clang 69.97% <ø> (ø)
#ubuntu_clang_debug 69.42% <ø> (ø)
#ubuntu_clang_inflate_allow_invalid_dist 69.72% <ø> (ø)
#ubuntu_clang_inflate_strict 69.99% <ø> (ø)
#ubuntu_clang_mmap 69.73% <ø> (ø)
#ubuntu_clang_msan ?
#ubuntu_gcc 72.16% <ø> (+0.47%) ⬆️
#ubuntu_gcc_aarch64 ?
#ubuntu_gcc_aarch64_compat_no_opt ?
#ubuntu_gcc_aarch64_no_acle ?
#ubuntu_gcc_aarch64_no_neon ?
#ubuntu_gcc_armhf ?
#ubuntu_gcc_armhf_compat_no_opt ?
#ubuntu_gcc_armhf_no_acle ?
#ubuntu_gcc_armhf_no_neon ?
#ubuntu_gcc_armsf ?
#ubuntu_gcc_armsf_compat_no_opt ?
#ubuntu_gcc_mingw_i686 70.23% <ø> (+0.02%) ⬆️
#ubuntu_gcc_mingw_x86_64 70.26% <ø> (-0.04%) ⬇️
#ubuntu_gcc_no_avx2 71.63% <ø> (ø)
#ubuntu_gcc_no_pclmulqdq 69.90% <ø> (ø)
#ubuntu_gcc_no_sse2 70.93% <ø> (ø)
#ubuntu_gcc_no_sse4 69.88% <ø> (ø)
#ubuntu_gcc_o3 ?
#ubuntu_gcc_osb ?
#ubuntu_gcc_ppc ?
#ubuntu_gcc_ppc64 ?
#ubuntu_gcc_ppc64le ?
#ubuntu_gcc_s390x ?
#ubuntu_gcc_sparc64 ?
#win64_gcc ?
#win64_gcc_compat_no_opt ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
infback.c 96.96% <ø> (-0.05%) ⬇️
chunkset.c 0.00% <0.00%> (-100.00%) ⬇️
trees_emit.h 0.00% <0.00%> (-69.34%) ⬇️
trees.c 5.70% <0.00%> (-60.87%) ⬇️
compare258.c 0.00% <0.00%> (-51.62%) ⬇️
adler32.c 35.29% <0.00%> (-49.71%) ⬇️
arch/x86/slide_sse.c 52.38% <0.00%> (-42.86%) ⬇️
zutil_p.h 0.00% <0.00%> (-40.00%) ⬇️
zutil.c 0.00% <0.00%> (-39.14%) ⬇️
arch/x86/adler32_ssse3.c 64.91% <0.00%> (-31.58%) ⬇️
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55680b...81d6598. Read the comment docs.

@Dead2 Dead2 merged commit 05d4a08 into zlib-ng:develop Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants