Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed qemu test runs for Ubuntu 20. #843

Merged
merged 2 commits into from Feb 14, 2021
Merged

Conversation

nmoinvaz
Copy link
Member

These changes are compatible for Ubuntu 18 too.

@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #843 (92e3dd0) into develop (da33bef) will decrease coverage by 1.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #843      +/-   ##
===========================================
- Coverage    76.81%   75.48%   -1.34%     
===========================================
  Files           59       71      +12     
  Lines         7631     8137     +506     
  Branches      1242     1339      +97     
===========================================
+ Hits          5862     6142     +280     
- Misses        1275     1484     +209     
- Partials       494      511      +17     
Flag Coverage Δ
macos_clang 68.59% <ø> (ø)
macos_gcc 67.77% <ø> (ø)
ubuntu_clang 68.59% <ø> (ø)
ubuntu_clang_debug 68.01% <ø> (ø)
ubuntu_clang_inflate_allow_invalid_dist 68.52% <ø> (ø)
ubuntu_clang_inflate_strict 68.79% <ø> (ø)
ubuntu_clang_mmap 68.56% <ø> (ø)
ubuntu_clang_msan 68.78% <ø> (ø)
ubuntu_gcc 72.43% <ø> (-1.11%) ⬇️
ubuntu_gcc_aarch64 70.13% <ø> (?)
ubuntu_gcc_aarch64_compat_no_opt 67.92% <ø> (?)
ubuntu_gcc_aarch64_no_acle 68.38% <ø> (?)
ubuntu_gcc_aarch64_no_neon 68.06% <ø> (?)
ubuntu_gcc_armhf 70.56% <ø> (?)
ubuntu_gcc_armhf_compat_no_opt 67.91% <ø> (?)
ubuntu_gcc_armhf_no_acle 69.63% <ø> (?)
ubuntu_gcc_armhf_no_neon 69.96% <ø> (?)
ubuntu_gcc_armsf 70.56% <ø> (?)
ubuntu_gcc_armsf_compat_no_opt 67.91% <ø> (?)
ubuntu_gcc_compat_no_opt 69.26% <ø> (ø)
ubuntu_gcc_no_avx2 69.50% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 66.27% <ø> (ø)
ubuntu_gcc_no_sse2 67.55% <ø> (ø)
ubuntu_gcc_no_sse4 66.27% <ø> (ø)
ubuntu_gcc_o3 68.94% <ø> (ø)
ubuntu_gcc_osb 70.36% <ø> (ø)
ubuntu_gcc_ppc 71.05% <ø> (?)
ubuntu_gcc_ppc64 70.22% <ø> (?)
ubuntu_gcc_ppc64le 69.18% <ø> (?)
ubuntu_gcc_s390x 68.40% <ø> (?)
ubuntu_gcc_sparc64 70.94% <ø> (?)
win64_gcc 73.10% <ø> (ø)
win64_gcc_compat_no_opt 74.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
functable.c 85.95% <0.00%> (-9.80%) ⬇️
deflate.h 8.33% <0.00%> (-8.34%) ⬇️
adler32_p.h 100.00% <0.00%> (ø)
arch/s390/dfltcc_detail.h 0.00% <0.00%> (ø)
arch/s390/dfltcc_common.c 89.65% <0.00%> (ø)
arch/arm/adler32_neon.c 100.00% <0.00%> (ø)
arch/arm/slide_neon.c 100.00% <0.00%> (ø)
arch/power/adler32_power8.c 100.00% <0.00%> (ø)
arch/arm/crc32_acle.c 61.29% <0.00%> (ø)
arch/s390/dfltcc_inflate.c 15.87% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da33bef...92e3dd0. Read the comment docs.

@Dead2
Copy link
Member

Dead2 commented Feb 13, 2021

From some of the ARM tests:

-- Performing Test HAVE_NO_INTERPOSITION
CMake Warning at cmake/detect-sanitizer.cmake:49 (message):
  Leak sanitizer is not supported when cross compiling
Call Stack (most recent call first):
  CMakeLists.txt:361 (add_address_sanitizer)

@nmoinvaz nmoinvaz force-pushed the fixes/ci-qemu branch 2 times, most recently from 9640527 to 92e3dd0 Compare February 14, 2021 02:29
@nmoinvaz
Copy link
Member Author

MinGW tests fails due to code coverage detection, but this PR should be okay to at least fix the qemu issues. I will make another PR to fix MinGW.

@Dead2 Dead2 merged commit 719b4d9 into zlib-ng:develop Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants