-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CMake macro for simple test executables #892
Conversation
6 tests use the same pattern: build a binary linked with zlib-ng and run it. At the moment this requires 5 near-identical lines of CMake code, leading to proliferation of copy-paste. Introduce a macro to get rid of it.
12fe089
to
baddb6d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #892 +/- ##
===========================================
- Coverage 75.43% 74.83% -0.60%
===========================================
Files 73 73
Lines 8220 7782 -438
Branches 1359 1357 -2
===========================================
- Hits 6201 5824 -377
+ Misses 1494 1420 -74
- Partials 525 538 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6 tests use the same pattern: build a binary linked with zlib-ng and
run it. At the moment this requires 5 near-identical lines of CMake
code, leading to proliferation of copy-paste. Introduce a macro to get
rid of it.