Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only perform auto-detection of floating point ABI on ARM arch. #898

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

nmoinvaz
Copy link
Member

-mfloat-abi does not apply to aarch64 so we need to check for arm arch before doing auto-detection.

…g#895

Co-authored-by: zhangn1985 <zhangn1985@users.noreply.github.com>
@nmoinvaz nmoinvaz force-pushed the fixes/aarch64-float-detection branch from 9384480 to 857ce43 Compare March 20, 2021 02:41
@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #898 (857ce43) into develop (bc33b26) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #898   +/-   ##
========================================
  Coverage    75.43%   75.43%           
========================================
  Files           73       73           
  Lines         8220     8220           
  Branches      1358     1358           
========================================
  Hits          6201     6201           
  Misses        1494     1494           
  Partials       525      525           
Flag Coverage Δ
macos_clang 68.73% <ø> (ø)
macos_gcc 67.76% <ø> (ø)
ubuntu_clang 68.92% <ø> (ø)
ubuntu_clang_debug 68.36% <ø> (ø)
ubuntu_clang_inflate_allow_invalid_dist 68.91% <ø> (ø)
ubuntu_clang_inflate_strict 69.17% <ø> (ø)
ubuntu_clang_mmap 68.92% <ø> (ø)
ubuntu_clang_msan 69.17% <ø> (ø)
ubuntu_gcc 69.85% <ø> (ø)
ubuntu_gcc_aarch64 70.07% <ø> (ø)
ubuntu_gcc_aarch64_compat_no_opt 67.78% <ø> (ø)
ubuntu_gcc_aarch64_no_acle 68.30% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 67.99% <ø> (ø)
ubuntu_gcc_armhf 70.49% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 67.77% <ø> (ø)
ubuntu_gcc_armhf_no_acle 69.54% <ø> (ø)
ubuntu_gcc_armhf_no_neon 69.86% <ø> (ø)
ubuntu_gcc_armsf 70.48% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 67.77% <ø> (ø)
ubuntu_gcc_compat_no_opt 69.14% <ø> (ø)
ubuntu_gcc_mingw_i686 0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <ø> (ø)
ubuntu_gcc_no_avx2 69.41% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 66.52% <ø> (ø)
ubuntu_gcc_no_sse2 67.77% <ø> (ø)
ubuntu_gcc_no_sse4 66.52% <ø> (ø)
ubuntu_gcc_o3 69.12% <ø> (ø)
ubuntu_gcc_osb 70.67% <ø> (ø)
ubuntu_gcc_ppc 70.91% <ø> (ø)
ubuntu_gcc_ppc64 70.08% <ø> (ø)
ubuntu_gcc_ppc64le 69.06% <ø> (ø)
ubuntu_gcc_s390x 68.27% <ø> (ø)
ubuntu_gcc_sparc64 70.79% <ø> (ø)
win64_gcc 73.02% <ø> (ø)
win64_gcc_compat_no_opt 74.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc33b26...857ce43. Read the comment docs.

Copy link
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dead2 Dead2 merged commit 2c8fd54 into zlib-ng:develop Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants