Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Format]: RVC Archive #87

Open
1 of 2 tasks
zly2006 opened this issue Jan 23, 2024 · 3 comments
Open
1 of 2 tasks

[New Format]: RVC Archive #87

zly2006 opened this issue Jan 23, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@zly2006
Copy link
Owner

zly2006 commented Jan 23, 2024

Please choose if applies:

  • I'm currently working on adding this feature.

Describe the solution you'd like

Currently, the RVC system works with git, so it is a folder, different from most other tools (e.g. litematica uses a single litematic file) and you should zip the entire folder to send your machine to others. (if you don't have a git server, this situation, is very common if RVCHub is not finished)

What about adding an archive file format which is a zipped .git directory? so RVC can also use a single file to share.

Describe alternatives you've considered

No response

Anything else?

No response

Please accept these terms

@zly2006 zly2006 added the enhancement New feature or request label Jan 23, 2024
zly2006 added a commit that referenced this issue Jan 24, 2024
link to #87: RVC Archive reading

Signed-off-by: Liyan Zhao <return65535@qq.com>
@zly2006
Copy link
Owner Author

zly2006 commented Jan 26, 2024

I have finished the import logic, but not sure about export:

  • How many branches should we export? or add an option to the export screen?
  • How should we optimize the file size? What about reflogs etc that are not necessary for export? what other objects should we ignore?

@Cubik65536

@SkyDynamic
Copy link

What items do we export? I want to konw details

@zly2006
Copy link
Owner Author

zly2006 commented Jan 26, 2024

What items do we export? I want to konw details

@SkyDynamic
As the name suggests, an archive format for rvc. rvc is based on git so all rvc data is in the .git folder.

I am implementing this format by simply adding all files in .git to a zip file with the extension ".rvcarchive", but i am still not sure what I should do to optimize its size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants